Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simpler IE9 support #48

Merged
merged 6 commits into from
Jan 26, 2015
Merged

Simpler IE9 support #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1152dfc
pre- and post-ie8.js bits
Jan 26, 2015
1b08341
wrap ie8.js in IE8 conditional
Jan 26, 2015
dc38e4c
new build
Jan 26, 2015
50fa127
use master branch for ie8
Jan 26, 2015
e8f6930
new build
Jan 26, 2015
0745f65
add some keywords
Jan 26, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
[submodule "lib/ie8"]
path = lib/ie8
url = git@github.com:shawnbot/ie8.git
branch = ie9
[submodule "lib/dom4"]
path = lib/dom4
url = git@github.com:shawnbot/dom4.git
Expand Down
2 changes: 2 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@ JS_FILES = \
lib/es5-shim/es5-shim.js \
lib/es5-shim/es5-sham.js \
src/aight.js \
src/before-ie8.js \
lib/ie8/src/ie8.js \
src/after-ie8.js \
lib/dom4/src/dom4.js \
lib/html5shiv/src/html5shiv.js \
src/css-om.js \
Expand Down
10 changes: 3 additions & 7 deletions aight.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1951,9 +1951,10 @@ if (!Object.isExtensible) {

aliasInterface(window, "HTMLCommentElement", "Comment");
aliasInterface(window, "HTMLDocument", "Document");
if (aight.browser.ie < 9) {

/*! (C) WebReflection Mit Style License */
// if (document.createEvent) return;
if (document.createEvent) return;
var
DUNNOABOUTDOMLOADED = true,
READYEVENTDISPATCHED = false,
Expand Down Expand Up @@ -2042,12 +2043,6 @@ if (!Object.isExtensible) {
var descriptor = getOwnPropertyDescriptor(
protoSource || protoDest, property
);

if (!descriptor) {
// console.warn("no fallback descriptor for ", protoDest, "#", property, " in ", protoSource);
return false;
}

defineProperty(
protoDest,
'textContent',
Expand Down Expand Up @@ -2577,6 +2572,7 @@ if (!Object.isExtensible) {
}}
}
);
} // if (aight.browser.ie < 9)
(function(window){'use strict';
/* jshint loopfunc: true, noempty: false*/
// http://www.w3.org/TR/dom/#element
Expand Down
4 changes: 2 additions & 2 deletions aight.min.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lib/ie8
Open in desktop
Submodule ie8 updated from 8671c8 to c163db
3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,13 @@
"keywords": [
"js",
"dom",
"es5",
"css",
"ie",
"ie8",
"ie9",
"windows",
"browser",
"compatibility"
],
"author": "Shawn Allen <shawn.allen@hush.com>",
Expand Down
1 change: 1 addition & 0 deletions src/after-ie8.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
} // if (aight.browser.ie < 9)
1 change: 1 addition & 0 deletions src/before-ie8.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
if (aight.browser.ie < 9) {