Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data - add option to merge two basedatas #493

Closed
GoogleCodeExporter opened this issue Mar 27, 2015 · 7 comments
Closed

data - add option to merge two basedatas #493

GoogleCodeExporter opened this issue Mar 27, 2015 · 7 comments
Assignees
@shawnlaffan
Labels
auto-migrated Priority-Medium randomisations Type-Enhancement
Milestone
Release_1.1

Comments

@GoogleCodeExporter
Copy link 

It would be useful to have the capacity to merge two, perhaps more, basedatas.  
This is probably most handy when a set of randomisations have been run in 
parallel and need to be reintegrated.

Original issue reported on code.google.com by shawnlaffan on 15 Aug 2014 at 9:36
@GoogleCodeExporter
Copy link
Author 

This issue was updated by revision r2676.

Add branch to work on this issue.

Original comment by shawnlaffan on 15 Aug 2014 at 9:38

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author 

Need to have two versions.  
1.  Merge two basedatas, adding sample counts, labels, groups etc.  Ignore 
outputs.  
2.  Merge outputs - labels, groups etc must be identical, as must the 
conditions on the analyses.  ALl that is really merged is the randomisation 
results.

Original comment by shawnlaffan on 15 Aug 2014 at 9:50

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author 

This issue was updated by revision r2677.

Add merge method to BaseData.pm.  
Add tests to go with it.

Original comment by shawnlaffan on 15 Aug 2014 at 11:25

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author 

This issue was updated by revision r2678.

Whitespace and formatting only.

Original comment by shawnlaffan on 15 Aug 2014 at 11:47

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author 

This issue was updated by revision r2985.

Merge recent trunk revisions across to the branch

Original comment by shawnlaffan on 27 Oct 2014 at 4:02

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author 

This issue was updated by revision r3099.

Merge recent trunk revisions across to the branch

Original comment by shawnlaffan on 4 Dec 2014 at 12:01

  • Added labels: ****
  • Removed labels: ****

@shawnlaffan shawnlaffan self-assigned this Apr 9, 2015
shawnlaffan added a commit that referenced this issue May 30, 2015
@shawnlaffan
Add basedata merge method plus tests.
ea5f652 
This is largely copied across from commit 5687b4b, but that branch was not merging cleanly so we will start a new branch.

Updates issue #493

Signed-off-by: Shawn Laffan <shawnlaffan@gmail.com>
shawnlaffan added a commit that referenced this issue May 30, 2015
@shawnlaffan
Add merge option to the GUI.
1a834f9 
This also involved adding a new options parameter type to access the index of a choice, rather than its text.

Shift the cellsize and origin matching checks into their own sub.

Updates issue #493

Signed-off-by: Shawn Laffan <shawnlaffan@gmail.com>
shawnlaffan added a commit that referenced this issue May 30, 2015
@shawnlaffan
Add merge option to the GUI.
35affd7 
This also involved adding a new options parameter type to access the index of a choice, rather than its text.

Shift the cellsize and origin matching checks into their own sub.

Updates issue #493

Signed-off-by: Shawn Laffan <shawnlaffan@gmail.com>
shawnlaffan added a commit that referenced this issue May 31, 2015
@shawnlaffan
Test that we get the correct sized element arrays after a merge.
d1f44b0 
Updates issue #493

Signed-off-by: Shawn Laffan <shawnlaffan@gmail.com>
@shawnlaffan
Copy link
Owner

Mark as fixed.

Very large data sets might need a progress dialogue, but that can be added later if needed.

Randomisations need to be integrated, taking into account existing outputs and the like. That can be done under its own issue, though.

@shawnlaffan shawnlaffan added this to the Release_1.01 milestone May 31, 2015
@shawnlaffan shawnlaffan mentioned this issue May 31, 2015
Closed
@shawnlaffan shawnlaffan mentioned this issue Jun 7, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawnlaffan shawnlaffan

Labels
auto-migrated Priority-Medium randomisations Type-Enhancement
Projects
None yet
Milestone
Release_1.1
Development

No branches or pull requests
2 participants
@shawnlaffan @GoogleCodeExporter