Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Randomisations - add option to hold some labels constant #556

Closed
shawnlaffan opened this issue Jun 7, 2015 · 1 comment
Closed

Randomisations - add option to hold some labels constant #556

shawnlaffan opened this issue Jun 7, 2015 · 1 comment
Assignees
@shawnlaffan
Labels
enhancement randomisations
Milestone
Release_1.1

Comments

@shawnlaffan
Copy link
Owner

In the randomisations it would be useful to be able to hold some of the labels constant, i.e. don't randomise them, but do the rest.

Integration with the GUI could be done by accessing the selected set from a view labels tab, or perhaps more simply by adding a method to copy the selected set to the clipboard.
@shawnlaffan shawnlaffan self-assigned this Jun 7, 2015
@shawnlaffan shawnlaffan mentioned this issue Jun 7, 2015
Closed
shawnlaffan added a commit that referenced this issue Jun 7, 2015
@shawnlaffan
Add capability to hold some set of labels constant in a randomisation.
4d6524d 
Extras include:

1.  The addition of a text widget to the parameters, albeit it needs to use similar tricks to the spatial conditions widgets so it does not take up too much real estate.

2.  A new method to add collated elements - add_elements_collated_by_label, indexed by label. Need to rename add_elements_collated to be explicit about groups.

The listing of labels in the GUI uses one label per line, which will cause problems if labels contain newlines.  No such cases are known yet, but it will probably crop up as an issue in the future.

Also remove one todo test in 28-Randomisation.t, as it is covered by an existing test.

Updates issue #556

Signed-off-by: Shawn Laffan <shawnlaffan@gmail.com>
@shawnlaffan shawnlaffan added this to the Release_1.01 milestone Jun 7, 2015
shawnlaffan added a commit that referenced this issue Jun 8, 2015
@shawnlaffan
add_elements_collated now handles empty groups if told to.
be00221 
This allows some refactoring of code in Biodiverse::Randomise::get_randomised_basedata.

Updates issue #556

Signed-off-by: Shawn Laffan <shawnlaffan@gmail.com>
shawnlaffan added a commit that referenced this issue Jun 8, 2015
@shawnlaffan
Hash randomisation was causing test failures.
036454c 
Now fixed by checking is_deeply on hashes, not the key arrays.  Checking the hashes is also more rigorous.

Updates issue #556

Signed-off-by: Shawn Laffan <shawnlaffan@gmail.com>
shawnlaffan added a commit that referenced this issue Jun 9, 2015
@shawnlaffan
Add test for when all labels are constant.
580d7f0 
Also trim down some redundant tests.  The removed tests were the using same hashes as the preceding tests.

No longer check if the count argument to _set_elements_hash_key_count is zero, as it has no effect anyway.  Keep negative and non-numeric, as they would indicate wrong arguments being passed.

Updates issue #556

Signed-off-by: Shawn Laffan <shawnlaffan@gmail.com>
@shawnlaffan
Copy link
Owner Author

Mark as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawnlaffan shawnlaffan

Labels
enhancement randomisations
Projects
None yet
Milestone
Release_1.1
Development

No branches or pull requests
1 participant
@shawnlaffan