Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trees - add option to trim to last common ancestor #670

Closed
shawnlaffan opened this issue Oct 11, 2017 · 1 comment
Closed

trees - add option to trim to last common ancestor #670

shawnlaffan opened this issue Oct 11, 2017 · 1 comment
Assignees
@shawnlaffan
Labels
enhancement
Milestone
Release_2.1

Comments

@shawnlaffan
Copy link
Owner

When trimming trees, it would be useful to remove any branches above the last common ancestor.
@shawnlaffan shawnlaffan added this to the Release_2.1 milestone Oct 11, 2017
@shawnlaffan shawnlaffan self-assigned this Oct 11, 2017
shawnlaffan added a commit that referenced this issue Dec 9, 2017
@shawnlaffan
Add capacity to trim trees to the last common ancestor
298f3fb 
Sets the root length to zero.

Updates #670
shawnlaffan added a commit that referenced this issue Dec 9, 2017
@shawnlaffan
Add capacity to trim trees to the last common ancestor
9b6db75 
Sets the root length to zero.

Updates #670
@shawnlaffan
Copy link
Owner Author

Mark as fixed

@shawnlaffan shawnlaffan mentioned this issue Jan 22, 2019
Closed
shawnlaffan added a commit that referenced this issue Apr 5, 2019
@shawnlaffan
Make sure to update the treenode ref when trimming to LCA
4d3dcb3 
Updates #721 and properly fixes #670, with better tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawnlaffan shawnlaffan

Labels
enhancement
Projects
None yet
Milestone
Release_2.1
Development

No branches or pull requests
1 participant
@shawnlaffan