Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add option to drop label and group axes #722

Closed
4 tasks done
shawnlaffan opened this issue Feb 28, 2019 · 1 comment
Closed
4 tasks done

add option to drop label and group axes #722

shawnlaffan opened this issue Feb 28, 2019 · 1 comment
Assignees
@shawnlaffan
Labels
enhancement
Milestone
Release_3

Comments

@shawnlaffan
Copy link
Owner

shawnlaffan commented Feb 28, 2019 •
edited
Loading

It can be convenient to remove one or more axes from labels or groups.

e.g. family:genus:species could be collapsed to genus:species or family:genus, or text axes could be removed from groups.

To do:

  • Croak if basedata has outputs (caller should clone first)
  • Croak if there will be no axes remaining
  • Add GUI options (these will clone the basedata first)
  • Test sample counts remain constant
@shawnlaffan shawnlaffan added this to the Release_3 milestone Feb 28, 2019
@shawnlaffan shawnlaffan self-assigned this Feb 28, 2019
@shawnlaffan shawnlaffan changed the title add otion to drop label and group axes add option to drop label and group axes Feb 28, 2019
shawnlaffan added a commit that referenced this issue May 1, 2019
@shawnlaffan
Add methods to drop group and label axes from a basedata
c4fc339 
Need to do it at the basedata level
to ensure groups/labels are kept in sync.

Updates #722
shawnlaffan added a commit that referenced this issue May 1, 2019
@shawnlaffan
Be less verbose
7eb4e1a 
Updates #722
shawnlaffan added a commit that referenced this issue May 1, 2019
@shawnlaffan
croak when basedata has existing outputs
3af0f35 
Updates #722
shawnlaffan added a commit that referenced this issue May 1, 2019
@shawnlaffan
Fix copy paste error, add test
47fdcfe 
Updates #722
shawnlaffan added a commit that referenced this issue May 1, 2019
@shawnlaffan
More fixes related to previous commit, add more tests
df6fecf 
Updates #722
shawnlaffan added a commit that referenced this issue May 1, 2019
@shawnlaffan
test some axes remain
0acc8a8 
Updates #722
shawnlaffan added a commit that referenced this issue May 1, 2019
@shawnlaffan
Add GUI interface to drop axes
cfd31ed 
Needs a bit of work, but that is not unique

Updates #722
shawnlaffan added a commit that referenced this issue May 1, 2019
@shawnlaffan
Use check boxes as we only have true/false options
5d764f7 
Plus a bit of associated cleanup

Updates #722
shawnlaffan added a commit that referenced this issue May 2, 2019
@shawnlaffan
Add test for sample counts
9687962 
Updates #722
@shawnlaffan
Copy link
Owner Author

Mark as fixed

@shawnlaffan shawnlaffan mentioned this issue Nov 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawnlaffan shawnlaffan

Labels
enhancement
Projects
None yet
Milestone
Release_3
Development

No branches or pull requests
1 participant
@shawnlaffan