Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indices: calc_net_vpd is undef when tree has been used for NRI/NTI beforehand, and vice versa #842

Closed
shawnlaffan opened this issue Dec 12, 2022 · 0 comments · Fixed by #844
Closed

Indices: calc_net_vpd is undef when tree has been used for NRI/NTI beforehand, and vice versa #842

shawnlaffan opened this issue Dec 12, 2022 · 0 comments · Fixed by #844
Labels
bug indices
Milestone
Release_4.1

Comments

@shawnlaffan
Copy link
Owner

It seems the NRI/NTI caching is incorrect.
@shawnlaffan shawnlaffan added this to the Release_4.1 milestone Dec 12, 2022
@shawnlaffan shawnlaffan changed the title Indices: calc_net_vpd is undef when tree has been used for NRI/NTI beforehand Indices: calc_net_vpd is undef when tree has been used for NRI/NTI beforehand, and vice versa Dec 13, 2022
shawnlaffan added a commit that referenced this issue Dec 13, 2022
@shawnlaffan
Indices VPD: Add more tests
cf1304b 
Needed for #842 where VPD is not calculated when
NRI/NTI have been previously calculated using the
same tree.
shawnlaffan added a commit that referenced this issue Dec 13, 2022
@shawnlaffan
_calc_nri_nti_expected_values: rebuild cache if variance is needed
a5929ac 
...and has not previously need calculated.

Updates #842
shawnlaffan added a commit that referenced this issue Dec 13, 2022
@shawnlaffan
Indices NRI/NTI/VPD: Make tests repeatable
034f1b8 
Updates #842
shawnlaffan added a commit that referenced this issue Dec 13, 2022
@shawnlaffan
Ensure NRI/NTI/VPD calculations are rerun if needed
3bb6542 
Otherwise they were being skipped if the cache was incomplete.

Updates #842
@shawnlaffan shawnlaffan mentioned this issue Dec 13, 2022
Merged
shawnlaffan added a commit that referenced this issue Dec 13, 2022
@shawnlaffan
Indices VPD: Add more tests
3f41edc 
Needed for #842 where VPD is not calculated when
NRI/NTI have been previously calculated using the
same tree.
shawnlaffan added a commit that referenced this issue Dec 13, 2022
@shawnlaffan
_calc_nri_nti_expected_values: rebuild cache if variance is needed
e55b521 
...and has not previously need calculated.

Updates #842
shawnlaffan added a commit that referenced this issue Dec 13, 2022
@shawnlaffan
Indices NRI/NTI/VPD: Make tests repeatable
e419e59 
Updates #842
shawnlaffan added a commit that referenced this issue Dec 13, 2022
@shawnlaffan
Ensure NRI/NTI/VPD calculations are rerun if needed
802e574 
Otherwise they were being skipped if the cache was incomplete.

Updates #842
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug indices
Projects
None yet
Milestone
Release_4.1
Development

Successfully merging a pull request may close this issue.

Issue 842 vpd shawnlaffan/biodiverse
1 participant
@shawnlaffan