Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suisin/74142/ts migration idv verified #28

Merged
merged 3 commits into from
Nov 17, 2022
Merged

Suisin/74142/ts migration idv verified #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d3838d
refactor: ts migration for idv-verified
suisin-deriv Nov 16, 2022
af2ef8d
Merge branch 'shayan/80609/components-shared-ts-migration-parent' of …
suisin-deriv Nov 16, 2022
4cf9e85
refactor: ts migration for idv-verified.spec.tsx
suisin-deriv Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/account/globals.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
declare module '*.svg' {
const content: any;
export default content;
}
7 changes: 2 additions & 5 deletions ...v-verified/__tests__/idv-verified.spec.js → ...-verified/__tests__/idv-verified.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,12 @@ describe('<IdvVerified />', () => {
expect(screen.getByText(submit_text)).toBeInTheDocument();
expect(history.location.pathname).not.toBe('/account/proof-of-address');
fireEvent.click(screen.getByText(submit_text));
expect(screen.getByRole('link', { name: submit_text }).closest('a')).toHaveAttribute(
'href',
'/account/proof-of-address'
);
expect(screen.getByRole('link', { name: submit_text })).toHaveAttribute('href', '/account/proof-of-address');
expect(history.location.pathname).toBe('/account/proof-of-address');
});

it('should render the IdvVerified component when needs_poa is false and is_from_external is true in mobile', () => {
isMobile.mockReturnValue(true);
(isMobile as jest.Mock).mockReturnValue(true);
renderWithRouter(<IdvVerified is_from_external />);
expect(screen.getByTestId('poi_idv_verified_container')).toBeInTheDocument();
expect(screen.getByText(/mockedsvgicon/i)).toBeInTheDocument();
Expand Down
7 changes: 6 additions & 1 deletion .../idv-status/idv-verified/idv-verified.jsx → .../idv-status/idv-verified/idv-verified.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,12 @@ import { localize } from '@deriv/translations';
import PoaButton from 'Components/poa/poa-button';
import IdvDocumentVerified from 'Assets/ic-idv-verified.svg';

const IdvVerified = ({ needs_poa, is_from_external }) => {
type TIdvVerified = {
needs_poa: boolean;
is_from_external: boolean;
};

const IdvVerified = ({ needs_poa, is_from_external }: Partial<TIdvVerified>) => {
const header_Text = needs_poa
? localize('Your ID is verified. You will also need to submit proof of your address.')
: localize('ID verification passed');
Expand Down
2 changes: 1 addition & 1 deletion packages/account/src/Components/poi/idv-status/idv-verified/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
import IdvVerified from './idv-verified.jsx';
import IdvVerified from './idv-verified';

export default IdvVerified;
1 change: 1 addition & 0 deletions packages/account/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"outDir": "./dist",
"baseUrl": "./",
"paths": {
"Assets/*": ["src/Assets/*"],
"Components/*": ["src/Components/*"],
"Containers/*": ["src/Containers/*"],
"Constants/*": ["src/Constants/*"],
Expand Down