fix: Fixed an image bug and parsing slides bug (#327)

shd101wyy · Oct 10, 2023 · 020f077 · 020f077
1 parent c906f48
commit 020f077
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,13 @@ Please visit https://github.com/shd101wyy/vscode-markdown-preview-enhanced/relea
 
 ## [Unreleased]
 
+## [0.8.22] - 2023-10-10
+
+### Bug fixes
+
+- Fixed a bug of loading image https://github.com/shd101wyy/vscode-markdown-preview-enhanced/issues/1819
+- Fixed a bug of parsing slides https://github.com/shd101wyy/vscode-markdown-preview-enhanced/issues/1818
+
 ## [0.8.21] - 2023-10-09
 
 ### Bug fixes

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "crossnote",
-  "version": "0.8.21",
+  "version": "0.8.22",
   "description": "A powerful markdown notebook tool",
   "keywords": [
     "markdown"

diff --git a/src/custom-markdown-it-features/widget.ts b/src/custom-markdown-it-features/widget.ts
@@ -36,7 +36,7 @@ export default (md: MarkdownIt, notebook: Notebook) => {
       }
     }
     */
-    if (token.children && token.children[0].content === '@embedding') {
+    if (token.children && token.children[0]?.content === '@embedding') {
       const error = token.attrGet('error') ?? '';
       if (error) {
         return atob(error);

diff --git a/src/markdown-engine/index.ts b/src/markdown-engine/index.ts
@@ -2210,7 +2210,10 @@ sidebarTOCBtn.addEventListener('click', function(event) {
     slideConfigs: JsonObject[],
     useRelativeFilePath: boolean,
   ) {
-    let slides = html.split(/^\s*<p[^>]+>\[CROSSNOTESLIDE\]<\/p>\s*/gm);
+    let slides = html.split(
+      /^\s*<p[^>]+><span>\[CROSSNOTESLIDE\]<\/span><\/p>\s*/gm,
+    );
+
     const before = slides[0];
     slides = slides.slice(1);
 

diff --git a/src/markdown-engine/transformer.ts b/src/markdown-engine/transformer.ts
@@ -432,7 +432,7 @@ export async function transformMarkdown(
                 lineNo = lineNo + newlines;
                 outputString =
                   outputString +
-                  `<p data-source-line="${lineNo + 1}">[CROSSNOTESLIDE]</p>` +
+                  `<span>[CROSSNOTESLIDE]</span>  ` +
                   '\n'.repeat(newlines);
                 continue;
               }