Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undesired highlight #474

Closed
delminskii opened this issue Mar 14, 2020 · 7 comments
Closed

Undesired highlight #474

delminskii opened this issue Mar 14, 2020 · 7 comments

Comments

@delminskii
Copy link

delminskii commented Mar 14, 2020

Does this bug happen when you install plugin without vim-polyglot?
No

Describe the bug:
First of all, take a look at this screen:
2020-03-14--1584176871_372x202_scrot
You may see here this calls' highlight like this option is enabled by default (I checked it out with vim-python/python-syntax plugin and that's all right with that there).
I use current stable neovim 0.4.3

To Reproduce:
Test some methods' calls in *.py files.

@sheerun
Copy link
Owner

sheerun commented Mar 14, 2020

" calls' highlights like thos option" - sorry I don't understand, could you explain again?

@delminskii
Copy link
Author

delminskii commented Mar 14, 2020

I am talking about g:python_highlight_func_calls option of https://github.com/vim-python/python-syntax plugin. If I try to use python-syntax directly it's OK with this option. But if I use this one (polyglot plugin) - then I see a picture I posted above.

sheerun added a commit that referenced this issue Apr 25, 2020
@sheerun
Copy link
Owner

sheerun commented Apr 25, 2020

If you update vim-polyglot, you can disable this by adding let g:python_highlight_func_calls = 0 to your vimrc :)

@sheerun sheerun closed this as completed Apr 25, 2020
@kevinhwang91
Copy link

@sheerun I think you should obey the g:python_highlight_all, it's default value is 0, If you think vim-polyglot should highlight all by default, you should make an option let the user disable it.

@sheerun sheerun reopened this May 22, 2020
@sheerun
Copy link
Owner

sheerun commented May 22, 2020

@kevinhwang91 If you have time to fix it then the place is ftdetect/polyglot.vim, if not I'll probably get to it next week

@sheerun
Copy link
Owner

sheerun commented May 22, 2020

until then you can disable individual options

@sheerun
Copy link
Owner

sheerun commented May 28, 2020

btw. if you look how github highlights syntax, it's the same thing (it highlights method calls):
https://github.com/scipy/scipy/blob/master/scipy/misc/common.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants