Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Vec<Vec<u8>> and std::backtrace::Backtrace #57

Merged
merged 3 commits into from
Jan 13, 2024

Conversation

fzyzcjy
Copy link
Contributor

@fzyzcjy fzyzcjy commented Jan 13, 2024

Without the fix, it errors like:

(base) ➜  allo-isolate git:(master) ✗ cargo test
warning: file `/Volumes/MyExternal/ExternalRefCode/allo-isolate/tests/containers.rs` found to be present in multiple build targets:
  * `example` target `containers`
  * `integration-test` target `containers`
   Compiling allo-isolate v0.1.23 (/Volumes/MyExternal/ExternalRefCode/allo-isolate)
error[E0277]: the trait bound `Vec<Vec<u8>>: IntoDart` is not satisfied
   --> tests/containers.rs:227:26
    |
227 |     assert!(isolate.post(vec![vec![10u8]]));
    |                     ---- ^^^^^^^^^^^^^^^^ the trait `IntoDart` is not implemented for `Vec<Vec<u8>>`
    |                     |
    |                     required by a bound introduced by this call
    |
    = help: the following other types implement trait `IntoDart`:
              Vec<i8>
              Vec<i16>
              Vec<i32>
              Vec<i64>
              Vec<u8>
              Vec<u16>
              Vec<u32>
              Vec<u64>
            and 3 others
note: required by a bound in `Isolate::post`
   --> /Volumes/MyExternal/ExternalRefCode/allo-isolate/src/lib.rs:133:34
    |
133 |     pub fn post(&self, msg: impl IntoDart) -> bool {
    |                                  ^^^^^^^^ required by this bound in `Isolate::post`

For more information about this error, try `rustc --explain E0277`.
error: could not compile `allo-isolate` (test "containers") due to previous error
warning: build failed, waiting for other jobs to finish...
(base) ➜  allo-isolate git:(master) ✗ 

@fzyzcjy fzyzcjy changed the title Fix types like Vec<Vec<u8>> Fix Vec<Vec<u8>> and std::backtrace::Backtrace Jan 13, 2024
Copy link
Owner

@shekohex shekohex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

@shekohex shekohex merged commit 3b68fbc into shekohex:master Jan 13, 2024
5 checks passed
@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Jan 13, 2024

You are welcome! Looking forward to next release

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Jan 13, 2024

So I wonder when will the next release be 👀

@shekohex
Copy link
Owner

Hey, sorry I did miss that. Will do a release shortly.

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Jan 14, 2024

It's OK, take your time!

@shekohex
Copy link
Owner

Released under v0.1.24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants