Fix common.expand error #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #709 +/- ##
==========================================
+ Coverage 94.66% 94.68% +0.01%
==========================================
Files 33 33
Lines 1219 1223 +4
==========================================
+ Hits 1154 1158 +4
Misses 65 65
Continue to review full report at Codecov.
|
nfischer
approved these changes
Apr 28, 2017
|
|
||
| test('non-string', t => { | ||
| const result = common.expand([5]); | ||
| t.falsy(shell.error()); |
There was a problem hiding this comment.
No need to check shell.error(), it's never set by this function (it's internal). Maybe just file a bug to clean up these tests later.
This was referenced Aug 29, 2019
This was referenced Mar 24, 2020
This was referenced Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #664