-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump dev dependencies to resolve install warnings #135
Conversation
For comparison, here's what a fresh install looks like after this PR: $ rm -rf node_modules/
$ npm install
npm WARN prepublish-on-install As of npm@5, `prepublish` scripts are deprecated.
npm WARN prepublish-on-install Use `prepare` for build steps and `prepublishOnly` for upload-only.
npm WARN prepublish-on-install See the deprecation note in `npm help scripts` for more information.
> shx@0.3.0 prepublish [path redacted]/shx
> npm run build
> shx@0.3.0 prebuild [path redacted]/shx
> rimraf lib
> shx@0.3.0 build [path redacted]/shx
> babel src -d lib
src/cli.js -> lib/cli.js
src/config.js -> lib/config.js
src/help.js -> lib/help.js
src/printCmdRet.js -> lib/printCmdRet.js
src/shx.js -> lib/shx.js
added 649 packages in 13.346s |
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 4 +1
Lines 25 68 +43
=====================================
+ Hits 25 68 +43
Continue to review full report at Codecov.
|
The coverage change looks like a bug with |
And I think v10.0.0 introduced a change where config.js:47 is also marked as uncovered:
|
LGTM |
9f20465
to
18eb42e
Compare
Newsflash! The new nyc version is not buggy--those were real coverage issues. Uploaded #139 to fix those (and marking this as blocked by that PR). |
This bumps codecov to avoid depending on graceful-fs < v4. Test: npm ls graceful-fs (nothing below v4)
18eb42e
to
3e7fefd
Compare
This bumps several dev dependencies to avoid depending on deprecated packages.
This also adds
package-lock.json
to eliminate those warnings and the hassleinvolved with constantly removing the uncommitted file.
Issue #134