Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all forms of !important are parsed #118

Closed
jwilsson opened this issue Sep 27, 2018 · 1 comment
Closed

Not all forms of !important are parsed #118

jwilsson opened this issue Sep 27, 2018 · 1 comment

Comments

@jwilsson
Copy link
Collaborator

jwilsson commented Sep 27, 2018

  • Node Version: 10.11.0
  • NPM Version: 6.4.1
  • postcss Version: 7.0.4
  • postcss-less Version: 3.0.2

If you have a large amount of code to share which demonstrates the problem you're experiencing, please provide a link to your
repository rather than pasting code. Otherwise, please paste relevant short snippets below.

LESS

.foo() !important;
.foo()!important;
.foo() ! important;
.foo()! important;

JavaScript

N/A

Expected Behavior

All of the examples above should yield an AST similar to this:

{
"raws": {
  ...
  important: ' ! important' // One for each example except the first one
},
...
"important": true
}

Actual Behavior

Only some of them yield this kind of AST.

How can we reproduce the behavior?

Run postcss-less on the examples above.

I'll take a look at a fix for it.

@shellscape
Copy link
Owner

Fixed in #126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants