Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proposed token important fix #126

Merged
merged 5 commits into from
Nov 15, 2018
Merged

fix: proposed token important fix #126

merged 5 commits into from
Nov 15, 2018

Conversation

shellscape
Copy link
Owner

Which issue # if any, does this resolve?
#118

Please check one:

  • New tests created for this change
  • Tests updated for this change

This PR:

  • Adds new API
  • Extends existing API, backwards-compatible
  • Introduces a breaking change
  • Fixes a bug

From #124

This should be a better approach to it than #119, the logic is mostly from core postcss. I'm hoping to find a way to consolidate it to one solution across both libraries.

This PR supersedes #124. It uses a different approach which alters the tokenizer when important identifiers are split between multiple tokens.

@shellscape shellscape requested a review from jwilsson November 14, 2018 13:50
@codecov-io
Copy link

codecov-io commented Nov 14, 2018

Codecov Report

Merging #126 into master will increase coverage by 0.26%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
+ Coverage   96.09%   96.36%   +0.26%     
==========================================
  Files           8        8              
  Lines         205      220      +15     
==========================================
+ Hits          197      212      +15     
  Misses          8        8
Impacted Files Coverage Δ
lib/LessParser.js 99.07% <100%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3731c3...da0daaf. Read the comment docs.

lib/LessParser.js Outdated Show resolved Hide resolved
test/parser/mixins.test.js Show resolved Hide resolved
test/parser/mixins.test.js Show resolved Hide resolved
@shellscape
Copy link
Owner Author

@jwilsson updated those two tests

@shellscape shellscape merged commit e8f1183 into master Nov 15, 2018
@shellscape shellscape deleted the shellscape/important branch November 15, 2018 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants