Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove .bind and map -> forEach #154

Closed
wants to merge 2 commits into from
Closed

remove .bind and map -> forEach #154

wants to merge 2 commits into from

Conversation

caub
Copy link

@caub caub commented Jun 19, 2018

No description provided.

@caub caub changed the title remove .bind and map - remove .bind and map -> forEach Jun 19, 2018
@codecov-io
Copy link

codecov-io commented Jun 19, 2018

Codecov Report

Merging #154 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #154   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines         111    108    -3     
  Branches       22     22           
=====================================
- Hits          111    108    -3
Impacted Files Coverage Δ
lib/plugin.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cad06c8...f8193a0. Read the comment docs.

@shellscape
Copy link
Owner

Thanks for opening this PR a while back, and I'm sorry that it didn't get attention sooner. We've landed a major refactor in #222 that has resulted in some significant changes, and some which has rendered your changes in this PR unneeded. Thanks again for contributing and I hope you'll consider doing so again in the future.

@shellscape shellscape closed this Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants