Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Group files by entry #183

Closed
wants to merge 2 commits into from
Closed

feat: Group files by entry #183

wants to merge 2 commits into from

Conversation

danpoq
Copy link

@danpoq danpoq commented Jan 31, 2019

These changes add a new option called groupByEntry.

When enabled the manifest will be grouped by each key in the entry if it's an object.

The following config:

{
  entry: {
    app: './app.js',
    store: './store.js'
  },
  ...
  optimization: {
    splitChunks: { chunks: 'all' }
  }
}

Will produce:

{
  "app": {
    "vendors~app.js": "/style/vendors~app.1234567890.js",
    "app.js": "/style/app.0987654321.js"
  },
  "store": {
    "vendors~app~store.js": "/style/vendors~app~store.1357913579.js",
    "store.js": "/style/store.0246802468.js"
  }
}

Looks like this was actually already suggested in a similar PR by @jacobwindsor #113 (comment).

Added a unit test that proves that the manifest will match this use case.

@shellscape
Copy link
Owner

@danpoq Thanks for opening this PR a while back, and I'm sorry that it didn't get attention sooner. We've landed a major refactor in #222 that has resulted in some significant conflicts. Would you be interested in reworking your PR on top of the new codebase?

@shellscape
Copy link
Owner

Closing as abandoned

@shellscape shellscape closed this Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants