v3 #197
Closed
v3 #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mastilver
force-pushed
the
next
branch
3 times, most recently
from
08fb497
to
d7e5948
Compare
Deprecated: node@6 webpack@2 webpack@3
mini-css-extract-plugin reports additional, incorrect information for files that are refenced in CSS. The first time we see the file the `module.userRequest` is correct, and we add to `moduleAssets` correctly. However mini-css-extract-plugin then also reports the same `file` but with `module.userRequest` set to the CSS file that references it, which caused us to overwrite the good value in `moduleAssets`. See the change in mini-css-extract-plugin that caused this webpack-contrib/mini-css-extract-plugin#177 fixes #167
Codecov Report
@@ Coverage Diff @@
## master #197 +/- ##
=========================================
Coverage ? 99.06%
=========================================
Files ? 2
Lines ? 107
Branches ? 22
=========================================
Hits ? 106
Misses ? 1
Partials ? 0
Continue to review full report at Codecov.
|
Webpack 5: Add "ids" to the retrieved JSON stats
|
The Replacing |
|
Closing for now, will take a look at the branch when we're ready to go that route. Please see #222 for more info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #195
fixes #167