Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read publicPath from stats to handle [hash] #215

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

maloguertin
Copy link
Contributor

This is a PR related to this issue I reported earlier: #214

The fix is pretty straight forward, read publicPath from stats in order to handle the [hash] placeholders.

@codecov-io
Copy link

Codecov Report

Merging #215 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #215   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         128    128           
  Branches       26     26           
=====================================
  Hits          128    128
Impacted Files Coverage Δ
lib/plugin.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b55ac5d...57ad037. Read the comment docs.

@maloguertin
Copy link
Contributor Author

Is this repo still managed?

@shellscape
Copy link
Owner

shellscape commented Oct 25, 2020

@maloguertin Thanks for opening this PR a while back, and I'm sorry that it didn't get attention sooner. (I recently took over maintenance of this repo). We've landed a major refactor in #222 that has resulted in some significant conflicts. Would you be interested in reworking your PR on top of the new codebase?

@maloguertin
Copy link
Contributor Author

@maloguertin Thanks for opening this PR a while back, and I'm sorry that it didn't get attention sooner. (I recently took over maintenance of this repo). We've landed a major refactor in #222 that has resulted in some significant conflicts. Would you be interested in reworking your PR on top of the new codebase?

I will try to get around to it in the next weeks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants