fix: make sure paths are consistent from os to os #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
==========================================
+ Coverage 98.57% 98.64% +0.07%
==========================================
Files 2 2
Lines 70 74 +4
==========================================
+ Hits 69 73 +4
Misses 1 1
Continue to review full report at Codecov.
|
a-x-
suggested changes
Sep 4, 2017
lib/plugin.js
Outdated
| @@ -110,6 +110,12 @@ ManifestPlugin.prototype.apply = function(compiler) { | |||
| }.bind(this)); | |||
| } | |||
|
|
|||
| files = files.map(file => { | |||
| file.name = file.name.replace('\\', '/'); | |||
| file.path = file.path.replace('\\', '/'); | |||
There was a problem hiding this comment.
'\\' is equivalent /\//
but /\//g expected
There was a problem hiding this comment.
'sdfds\\sdfsdf\\'.replace('\\', '/') // -> "sdfds/sdfsdf\"
'sdfds\\sdfsdf\\'.replace(/\\/, '/') // -> "sdfds/sdfsdf\"
'sdfds\\sdfsdf\\'.replace(/\\/g, '/') // -> "sdfds/sdfsdf/"
spec/plugin.spec.js
Outdated
| webpackCompile({ | ||
| context: __dirname, | ||
| entry: { | ||
| 'dir\\main': './fixtures/file.js' |
mastilver
force-pushed
the
unixify-paths
branch
from
c578e38 to
1adf3ef
Compare
|
@a-x- fixed the issue you spotted :) |
a-x-
approved these changes
Sep 8, 2017
This was referenced Jan 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #60