Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Windows color #1

Merged
merged 1 commit into from
Apr 26, 2017
Merged

fix Windows color #1

merged 1 commit into from
Apr 26, 2017

Conversation

mattn
Copy link
Contributor

@mattn mattn commented Apr 26, 2017

brename

@shenwei356 shenwei356 merged commit 35199f9 into shenwei356:master Apr 26, 2017
@shenwei356
Copy link
Owner

Thank you so much! Finally solve it. I can fix other tools now! 😄

@shenwei356
Copy link
Owner

shenwei356 commented Apr 26, 2017

It's not perfect yet. [ERRO] should be red too :(

@shenwei356
Copy link
Owner

shenwei356 commented Apr 26, 2017

@mattn Oh, no!

https://github.com/op/go-logging/blob/master/format.go#L186

Colors on Windows is unfortunately not supported right now and is currently a no-op.

But I remembered it supports several months ago.

@mattn
Copy link
Contributor Author

mattn commented Apr 26, 2017

The author of go-logging maybe not know go-colorable.

@mattn mattn deleted the windows-color branch April 26, 2017 01:14
@shenwei356
Copy link
Owner

Yes no forks of go-logging tried to fix it.

@shenwei356
Copy link
Owner

Can you help to improve go-logging with go-colorable. I tried and failed.

@mattn
Copy link
Contributor Author

mattn commented Apr 26, 2017

@shenwei356
Copy link
Owner

shenwei356 commented Apr 26, 2017

More code to be added: https://github.com/op/go-logging/blob/970db520ece77730c7e4724c61121037378659d9/log_windows.go#L104

I tried but can't figure it out.

@mattn
Copy link
Contributor Author

mattn commented Apr 26, 2017

  1. remove log_windows.go
  2. put build-constraints for windows into log_nix.go

@shenwei356
Copy link
Owner

Thanks you @mattn , it works !!!!

I'll create a pull request to go-logging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants