Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seqkit handles empty files inconsitently #36

Closed
nr0cinu opened this issue Aug 1, 2018 · 2 comments
Closed

seqkit handles empty files inconsitently #36

nr0cinu opened this issue Aug 1, 2018 · 2 comments

Comments

@nr0cinu
Copy link

nr0cinu commented Aug 1, 2018

Hi!

seqkit exits with 1 when getting an empty file. I use seqkit in scripts and makefiles, and sometimes the fasta files processed are empty and imho they should be treated like any file containing sequences.

seqkit also handles empty files and files just contain one newline differently:

$ touch file.fasta; seqkit seq file.fasta; echo $?
2018/08/01 11:34:36 EOF
1
$ echo > file.fasta; seqkit seq file.fasta; echo $?
0

Would be nice if the first command would exit with 0 without any messages? or to have a flag to enable this behaviour?

Thanks :)
Bela

shenwei356 added a commit that referenced this issue Aug 1, 2018
@shenwei356
Copy link
Owner

Hi Bela,

Thanks for reporting this. It's fixed now, you can try the dev version: v0.8.2-dev.

Tell me if you have more questions.

Wei

@nr0cinu
Copy link
Author

nr0cinu commented Aug 1, 2018

Works! Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants