Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update #57

Merged
merged 8 commits into from
Sep 27, 2023
Merged

update #57

merged 8 commits into from
Sep 27, 2023

Conversation

shenyangHuang
Copy link
Owner

@shenyangHuang shenyangHuang commented Aug 21, 2023 •
edited
Loading

  • remove unused scripts such as _tvi.py scripts
  • remove count_new_nodes.py
  • sorted edgelist for tgbl-coin and tgbl-flight
  • regenerate ns samples

@shenyangHuang shenyangHuang requested a review from fpour August 21, 2023 20:05
@shenyangHuang shenyangHuang self-assigned this Aug 21, 2023
@shenyangHuang shenyangHuang marked this pull request as draft August 21, 2023 20:09
fpour
fpour reviewed Aug 21, 2023
View reviewed changes
examples/linkproppred/tgbl-wiki/tgn_tvi.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we have this as a sample for later reference?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will be in the commit history so we can always find it in the future, having it in the example will confuse people since it is not for the MRR we reported in the paper.

fpour
fpour reviewed Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@fpour fpour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we preserve one sample tgn_tvi.py file?! In case we need this for after rebuttal...

@shenyangHuang shenyangHuang marked this pull request as ready for review September 27, 2023 20:16
@shenyangHuang shenyangHuang merged commit 6d859be into main Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpour fpour fpour left review comments

Assignees

@shenyangHuang shenyangHuang

Labels
None yet
Projects
None yet
Milestone
Dataloading and Processing
Development

Successfully merging this pull request may close these issues.
2 participants
@shenyangHuang @fpour