Do not provide nil values for missing connection pool options

Fixes redis-store#44
shepmaster · Dec 19, 2018 · 8edcb1d · 8edcb1d
1 parent 34d60c7
commit 8edcb1d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/lib/redis/rack/connection.rb b/lib/redis/rack/connection.rb
@@ -35,7 +35,7 @@ def pool_options
         {
           size: @options[:pool_size],
           timeout: @options[:pool_timeout]
-        }
+        }.reject { |key, value| value.nil? }.to_h
       end
     end
   end

diff --git a/test/redis/rack/connection_test.rb b/test/redis/rack/connection_test.rb
@@ -62,6 +62,17 @@ def setup
         conn.pooled?.must_equal false
         conn.store.to_s.must_match(/127\.0\.0\.1:6380 against DB 1$/)
       end
+
+      it "does not include nil options for the connection pool" do
+        conn = Connection.new
+        conn.pool_options.must_be_empty
+
+        conn = Connection.new(pool_size: nil)
+        conn.pool_options.must_be_empty
+
+        conn = Connection.new(pool_timeout: nil)
+        conn.pool_options.must_be_empty
+      end
     end
   end
 end