Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a linking issue with integers, and updates the Python code
to run the correct interpreter and use the proper DLL names.
integers
The problem here is that, on Windows, if you don't use any symbols from
the standard library and create a dynamic library, linking will fail.
This is a known issue (rust-lang/rust#18807) and the only half-way decent
solution is to include a dead function that does use something from the
standard library.
Python
Two changes. First, I've added a hashbang to invoke the correct Python
interpreter. On Windows, it's common to execute scripts directly without
specifying the interpreter. In addition, it is not common to have
multiple versions of Python accessible on the PATH at one time. As such,
Python on Windows comes with a "launcher" that reads the hashbang and
executes the appropriate version of Python.
Anyone with Python 3.x installed will almost certainly have that as the
default, so indicating that the script needs Python 2.x specifically is
a really good idea.
Also, the existing examples do not correctly determine the name of the
Windows libraries being loaded. Two things: they end in
.dll
and theydo not start with
lib
.Miscellaneous
I have made no attempt to get these working on Windows, as the examples just immediately segfault for no apparent reason and, to be honest, I don't care enough about Ruby to work out why. :P
I'm also working on doc changes separately.