Make source(from) imply source(true)
#129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #124 - based on discussion from #109 about which attributes should be valid together.
This change makes
source(from(...))implysource(true). This means you don't need twosource-type attributes on a field that you intend to be a source but can't be namedsource. (It's still valid to specifysource(from(...))andsource(true), just redundant.)The
attributessection of the user's guide is updated with a note on this behavior.Testing done:
Updated compile-fail results show that we catch more duplicates than we could before, because more fields are recognized as sources.
An updated unit test also shows this behavior in a more positive light. :)