-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make "backtraces" feature opt-in #157
Conversation
149c289
to
8ddb7bd
Compare
b457393
to
b91fb2a
Compare
Rebased to latest master (and fixed a bunch of conflicts), CI is green. |
My plan is to take this PR and PR #173 and ensure that they play well together locally before I merge either, then merge them separately. Since our goal is to support the standard-library backtrace and that will be always available in some future Rust version, that's the general setup I want to mimic. I think this PR sets us up in that direction, but I don't know if it will be the final goal. Let's assume that standard-library backtraces stabilize in Rust 1.50. My plan is that this library would grow a |
I'll take care of addressing these conflicts, as part of that local testing! |
03d9ca6
to
51de49f
Compare
This moves the "backtraces" feature out of the default set. It also links the `Backtrace` implementation to the feature, so that the public type always exists but it does not carry any backtrace content unless the consumer explicitely enabled that.
51de49f
to
2424454
Compare
Thanks! |
This moves the "backtraces" feature out of the default set. It also
links the
Backtrace
implementation to the feature, so that thepublic type always exists but it does not carry any backtrace content
unless the consumer explicitely enabled that.
Closes: #113