Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate syn to v2 #382

Merged
merged 1 commit into from
Aug 19, 2023
Merged

Migrate syn to v2 #382

merged 1 commit into from
Aug 19, 2023

Conversation

Enet4
Copy link
Collaborator

@Enet4 Enet4 commented Jul 2, 2023

Resolves #379, but depends on #381. I am leaving the PR in advance so that it can be reviewed when the time is right.

Summary

  • change LifetimeDef to LifetimeParam
  • change field access path to method call path()
  • change DocComment to comply with meta attribute parsing

@netlify
Copy link

netlify bot commented Jul 2, 2023

Deploy Preview for shepmaster-snafu ready!

Name Link
🔨 Latest commit 092fd04
🔍 Latest deploy log https://app.netlify.com/sites/shepmaster-snafu/deploys/64e150009d509f000776958c
😎 Deploy Preview https://deploy-preview-382--shepmaster-snafu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Enet4 Enet4 force-pushed the change/syn_2 branch 2 times, most recently from dccb631 to 4bc15c8 Compare July 10, 2023 16:25
@shepmaster shepmaster force-pushed the change/syn_2 branch 2 times, most recently from ae1bb58 to 2f72a79 Compare August 19, 2023 23:02
@shepmaster shepmaster marked this pull request as ready for review August 19, 2023 23:24
- change LifetimeDef to LifetimeParam
- change field access `path` to method call `path()`
- change `DocComment` to comply with attribute parsing
- change quote and proc-macro2 versions to match syn's
@shepmaster shepmaster merged commit d71903a into shepmaster:main Aug 19, 2023
@Enet4 Enet4 deleted the change/syn_2 branch August 20, 2023 07:16
@shepmaster shepmaster added the breaking change Likely requires a SemVer version bump label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Likely requires a SemVer version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

snafu-derive syn is still in v1.0
2 participants