Fix Review #1

sherlock-admin · 2024-12-02T12:25:08Z

Fix Review of

Repo: mento-protocol/mento-core
Commit Hash: f4e3b950b4beea4f94fd0dcd0b7170c4e86f9cf7

sherlock-admin · 2024-12-02T12:25:34Z

mento-core/contracts/goodDollar/BancorExchangeProvider.sol

+
+    if (tokenIn == exchange.tokenAddress) {
+      require(scaledAmountIn < exchange.tokenSupply, "amountIn is greater than tokenSupply");
+      // apply exit contribution
+      scaledAmountIn = (scaledAmountIn * (MAX_WEIGHT - exchange.exitContribution)) / MAX_WEIGHT;
+    }
+


Change related to mento-protocol/mento-core#557.

Fixes issues: #36, #64

sherlock-admin · 2024-12-02T12:25:36Z

mento-core/contracts/goodDollar/BancorExchangeProvider.sol

+
+    if (tokenIn == exchange.tokenAddress) {
+      // apply exit contribution
+      scaledAmountIn = (scaledAmountIn * MAX_WEIGHT) / (MAX_WEIGHT - exchange.exitContribution);
+      require(scaledAmountIn < exchange.tokenSupply, "amountIn is greater than tokenSupply");
+    }
+


Change related to mento-protocol/mento-core#557.

Fixes issues: #36, #64

sherlock-admin · 2024-12-02T12:25:38Z

mento-core/contracts/goodDollar/BancorExchangeProvider.sol

    PoolExchange memory exchange = getPoolExchange(exchangeId);
    uint256 scaledReserveRatio = uint256(exchange.reserveRatio) * 1e10;
+


Change related to mento-protocol/mento-core#560.

Fixes issues: #23

sherlock-admin · 2024-12-02T12:25:40Z

mento-core/contracts/goodDollar/BancorExchangeProvider.sol

+    uint256 priceScaled = unwrap(wrap(exchange.reserveBalance).div(denominator));
+
+    price = priceScaled / tokenPrecisionMultipliers[exchange.reserveAsset];


Change related to mento-protocol/mento-core#560.

Fixes issues: #23

sherlock-admin · 2024-12-02T12:25:42Z

mento-core/contracts/goodDollar/BancorExchangeProvider.sol

@@ -165,9 +180,9 @@ contract BancorExchangeProvider is IExchangeProvider, IBancorExchangeProvider, B

  /// @inheritdoc IBancorExchangeProvider
  function setReserve(address _reserve) public onlyOwner {
-    require(address(_reserve) != address(0), "Reserve address must be set");
+    require(_reserve != address(0), "Reserve address must be set");


Change related to mento-protocol/mento-core#545.

Fixes issues: #79

sherlock-admin · 2024-12-02T12:25:43Z

mento-core/contracts/goodDollar/BancorExchangeProvider.sol

    reserve = IReserve(_reserve);
-    emit ReserveUpdated(address(_reserve));
+    emit ReserveUpdated(_reserve);


Change related to mento-protocol/mento-core#545.

Fixes issues: #79

sherlock-admin · 2024-12-02T12:25:45Z

mento-core/contracts/goodDollar/BancorExchangeProvider.sol

+    uint256 exitContribution = 0;
+
+    if (tokenIn == exchange.tokenAddress) {
+      require(scaledAmountIn < exchange.tokenSupply, "amountIn is greater than tokenSupply");
+      // apply exit contribution
+      exitContribution = (scaledAmountIn * exchange.exitContribution) / MAX_WEIGHT;
+      scaledAmountIn -= exitContribution;
+    }
+


Change related to mento-protocol/mento-core#557.

Fixes issues: #36, #64

sherlock-admin · 2024-12-02T12:25:47Z

mento-core/contracts/goodDollar/BancorExchangeProvider.sol

    uint256 scaledAmountOut = _getScaledAmountOut(exchange, tokenIn, tokenOut, scaledAmountIn);
+


Change related to mento-protocol/mento-core#557.

Fixes issues: #36, #64

sherlock-admin · 2024-12-02T12:25:49Z

mento-core/contracts/goodDollar/BancorExchangeProvider.sol

+    if (exitContribution > 0) {
+      _accountExitContribution(exchangeId, exitContribution);
+    }


Change related to mento-protocol/mento-core#557.

Fixes issues: #36, #64

sherlock-admin · 2024-12-02T12:25:50Z

mento-core/contracts/goodDollar/BancorExchangeProvider.sol

+
+    uint256 exitContribution = 0;
+    uint256 scaledAmountInWithExitContribution = scaledAmountIn;
+
+    if (tokenIn == exchange.tokenAddress) {
+      // apply exit contribution
+      scaledAmountInWithExitContribution = (scaledAmountIn * MAX_WEIGHT) / (MAX_WEIGHT - exchange.exitContribution);
+      require(
+        scaledAmountInWithExitContribution < exchange.tokenSupply,
+        "amountIn required is greater than tokenSupply"
+      );
+      exitContribution = scaledAmountInWithExitContribution - scaledAmountIn;
+    }
+


Change related to mento-protocol/mento-core#557.

Fixes issues: #36, #64

sherlock-admin · 2024-12-02T12:25:52Z

mento-core/contracts/goodDollar/BancorExchangeProvider.sol

+    if (exitContribution > 0) {
+      _accountExitContribution(exchangeId, exitContribution);
+    }


Change related to mento-protocol/mento-core#557.

Fixes issues: #36, #64

sherlock-admin · 2024-12-02T12:25:54Z

mento-core/contracts/goodDollar/BancorExchangeProvider.sol


-    amountIn = scaledAmountIn / tokenPrecisionMultipliers[tokenIn];
+    amountIn = scaledAmountInWithExitContribution / tokenPrecisionMultipliers[tokenIn];


Change related to mento-protocol/mento-core#557.

Fixes issues: #36, #64

sherlock-admin · 2024-12-02T12:25:56Z

mento-core/contracts/goodDollar/BancorExchangeProvider.sol

@@ -262,7 +307,7 @@ contract BancorExchangeProvider is IExchangeProvider, IBancorExchangeProvider, B

  function _setExitContribution(bytes32 exchangeId, uint32 exitContribution) internal {
    require(exchanges[exchangeId].reserveAsset != address(0), "Exchange does not exist");
-    require(exitContribution <= MAX_WEIGHT, "Exit contribution is too high");
+    require(exitContribution < MAX_WEIGHT, "Exit contribution is too high");


Change related to mento-protocol/mento-core#549.

Fixes issues: #55

sherlock-admin · 2024-12-02T12:25:58Z

mento-core/contracts/goodDollar/BancorExchangeProvider.sol

+  /**
+   * @notice Accounting of exit contribution on a swap.
+   * @dev Accounting of exit contribution without changing the current price of an exchange.
+   * this is done by updating the reserve ratio and subtracting the exit contribution from the token supply.
+   * Formula: newRatio = (Supply * oldRatio) / (Supply - exitContribution)
+   * @param exchangeId The ID of the pool
+   * @param exitContribution The amount of the token to be removed from the pool, scaled to 18 decimals
+   */
+  function _accountExitContribution(bytes32 exchangeId, uint256 exitContribution) internal {
+    PoolExchange memory exchange = getPoolExchange(exchangeId);
+    uint256 scaledReserveRatio = uint256(exchange.reserveRatio) * 1e10;
+    UD60x18 nominator = wrap(exchange.tokenSupply).mul(wrap(scaledReserveRatio));
+    UD60x18 denominator = wrap(exchange.tokenSupply - exitContribution);
+    UD60x18 newRatioScaled = nominator.div(denominator);
+
+    uint256 newRatio = unwrap(newRatioScaled) / 1e10;
+
+    exchanges[exchangeId].reserveRatio = uint32(newRatio);
+    exchanges[exchangeId].tokenSupply -= exitContribution;
+  }
+


Change related to mento-protocol/mento-core#557.

Fixes issues: #36, #64

sherlock-admin · 2024-12-02T12:25:59Z

mento-core/contracts/goodDollar/BancorExchangeProvider.sol

@@ -362,6 +424,7 @@ contract BancorExchangeProvider is IExchangeProvider, IBancorExchangeProvider, B
    require(exchange.reserveRatio > 1, "Reserve ratio is too low");
    require(exchange.reserveRatio <= MAX_WEIGHT, "Reserve ratio is too high");
    require(exchange.exitContribution <= MAX_WEIGHT, "Exit contribution is too high");
+    require(exchange.reserveBalance > 0, "Reserve balance must be greater than 0");


Change related to mento-protocol/mento-core#558.

Fixes issues: #57

sherlock-admin · 2024-12-02T12:26:01Z

mento-core/contracts/goodDollar/GoodDollarExchangeProvider.sol

+
+    // The division and multiplication by 1e10 here ensures that the new ratio used for calculating the amount to mint
+    // is the same as the one set in the exchange but only scaled to 18 decimals.
+    // Ignored, because the division and multiplication by 1e10 is needed see comment above.
+    // slither-disable-next-line divide-before-multiply
+    UD60x18 newRatio = wrap((unwrap(scaledRatio.mul(wrap(reserveRatioScalar))) / 1e10) * 1e10);


Change related to mento-protocol/mento-core#548.

Fixes issues: #21

sherlock-admin · 2024-12-02T12:26:03Z

mento-core/contracts/goodDollar/GoodDollarExchangeProvider.sol

@@ -190,21 +195,31 @@ contract GoodDollarExchangeProvider is IGoodDollarExchangeProvider, BancorExchan
  /**
   * @inheritdoc IGoodDollarExchangeProvider
   * @dev Calculates the new reserve ratio needed to mint the G$ reward while keeping the current price the same.
-   *      calculation: newRatio = reserveBalance / (tokenSupply + reward) * currentPrice
+   *      calculation: newRatio = (tokenSupply * reserveRatio) / (tokenSupply + reward)


Change related to mento-protocol/mento-core#554.

Fixes issues: #59

sherlock-admin · 2024-12-02T12:26:05Z

mento-core/contracts/goodDollar/GoodDollarExchangeProvider.sol

+  function updateRatioForReward(
+    bytes32 exchangeId,
+    uint256 reward,
+    uint256 maxSlippagePercentage
+  ) external onlyExpansionController whenNotPaused {


Change related to mento-protocol/mento-core#554.

Fixes issues: #59

sherlock-admin · 2024-12-02T12:26:07Z

mento-core/contracts/goodDollar/GoodDollarExchangeProvider.sol

+    uint256 scaledRatio = uint256(exchange.reserveRatio) * 1e10;
+    uint256 scaledReward = reward * tokenPrecisionMultipliers[exchange.tokenAddress];
+
+    UD60x18 numerator = wrap(exchange.tokenSupply).mul(wrap(scaledRatio));
+    UD60x18 denominator = wrap(exchange.tokenSupply).add(wrap(scaledReward));
+    uint256 newScaledRatio = unwrap(numerator.div(denominator));


Change related to mento-protocol/mento-core#554.

Fixes issues: #59

sherlock-admin · 2024-12-02T12:26:08Z

mento-core/contracts/goodDollar/GoodDollarExchangeProvider.sol

+    UD60x18 denominator = wrap(exchange.tokenSupply).add(wrap(scaledReward));
+    uint256 newScaledRatio = unwrap(numerator.div(denominator));
+
+    uint32 newRatioUint = uint32(newScaledRatio / 1e10);


Change related to mento-protocol/mento-core#554.

Fixes issues: #59

sherlock-admin · 2024-12-02T12:26:10Z

mento-core/contracts/goodDollar/GoodDollarExchangeProvider.sol

+    require(newRatioUint > 0, "New ratio must be greater than 0");



Change related to mento-protocol/mento-core#544.

Fixes issues: #29

sherlock-admin · 2024-12-02T12:26:12Z

mento-core/contracts/goodDollar/GoodDollarExchangeProvider.sol

+    uint256 allowedSlippage = (exchange.reserveRatio * maxSlippagePercentage) / MAX_WEIGHT;
+    require(exchange.reserveRatio - newRatioUint <= allowedSlippage, "Slippage exceeded");



Change related to mento-protocol/mento-core#554.

Fixes issues: #59

sherlock-admin · 2024-12-02T12:26:14Z

mento-core/contracts/goodDollar/GoodDollarExchangeProvider.sol

    exchanges[exchangeId].reserveRatio = newRatioUint;
-    exchanges[exchangeId].tokenSupply += rewardScaled;
+    exchanges[exchangeId].tokenSupply += scaledReward;


Change related to mento-protocol/mento-core#554.

Fixes issues: #59

sherlock-admin · 2024-12-02T12:26:16Z

mento-core/contracts/goodDollar/GoodDollarExpansionController.sol

@@ -5,24 +5,27 @@ import { IGoodDollarExpansionController } from "contracts/interfaces/IGoodDollar
 import { IGoodDollarExchangeProvider } from "contracts/interfaces/IGoodDollarExchangeProvider.sol";
 import { IBancorExchangeProvider } from "contracts/interfaces/IBancorExchangeProvider.sol";
 import { IERC20 } from "openzeppelin-contracts-next/contracts/token/ERC20/IERC20.sol";
+import { IERC20Metadata } from "openzeppelin-contracts-next/contracts/token/ERC20/extensions/IERC20Metadata.sol";


Change related to mento-protocol/mento-core#551.

Fixes issues: #7

sherlock-admin · 2024-12-02T12:26:17Z

mento-core/contracts/goodDollar/GoodDollarExpansionController.sol

 import { OwnableUpgradeable } from "openzeppelin-contracts-upgradeable/contracts/access/OwnableUpgradeable.sol";
 import { unwrap, wrap, powu } from "prb/math/UD60x18.sol";

 /**
 * @title GoodDollarExpansionController
 * @notice Provides functionality to expand the supply of GoodDollars.
 */
-contract GoodDollarExpansionController is IGoodDollarExpansionController, PausableUpgradeable, OwnableUpgradeable {
+contract GoodDollarExpansionController is IGoodDollarExpansionController, OwnableUpgradeable {


Change related to mento-protocol/mento-core#552.

Fixes issues: #49

sherlock-admin · 2024-12-02T12:26:19Z

mento-core/contracts/goodDollar/GoodDollarExpansionController.sol

+  // EXPANSION_MAX_WEIGHT is the max rate that can be assigned to an exchange
+  uint256 public constant EXPANSION_MAX_WEIGHT = 1e18;
+
+  // BANCOR_MAX_WEIGHT is used for BPS calculations in GoodDollarExchangeProvider
+  uint32 public constant BANCOR_MAX_WEIGHT = 1e8;


Change related to mento-protocol/mento-core#554.

Fixes issues: #59

sherlock-admin · 2024-12-02T12:26:21Z

mento-core/contracts/goodDollar/GoodDollarExpansionController.sol

@@ -123,7 +125,7 @@ contract GoodDollarExpansionController is IGoodDollarExpansionController, Pausab

  /// @inheritdoc IGoodDollarExpansionController
  function setExpansionConfig(bytes32 exchangeId, uint64 expansionRate, uint32 expansionFrequency) external onlyAvatar {
-    require(expansionRate < MAX_WEIGHT, "Expansion rate must be less than 100%");
+    require(expansionRate < EXPANSION_MAX_WEIGHT, "Expansion rate must be less than 100%");


Change related to mento-protocol/mento-core#554.

Fixes issues: #59

sherlock-admin · 2024-12-02T12:26:23Z

mento-core/contracts/goodDollar/GoodDollarExpansionController.sol

+    uint256 contractReserveBalance = IERC20(exchange.reserveAsset).balanceOf(reserve) *
+      (10 ** (18 - IERC20Metadata(exchange.reserveAsset).decimals()));
+


Change related to mento-protocol/mento-core#551.

Fixes issues: #7

sherlock-admin · 2024-12-02T12:26:24Z

mento-core/contracts/goodDollar/GoodDollarExpansionController.sol

@@ -172,11 +176,10 @@ contract GoodDollarExpansionController is IGoodDollarExpansionController, Pausab
      .getPoolExchange(exchangeId);
    ExchangeExpansionConfig memory config = getExpansionConfig(exchangeId);

-    bool shouldExpand = block.timestamp > config.lastExpansion + config.expansionFrequency;
+    bool shouldExpand = block.timestamp >= config.lastExpansion + config.expansionFrequency;


Change related to mento-protocol/mento-core#553.

Fixes issues: #50

Fix Review

9b85cc1

sherlock-admin commented Dec 2, 2024

View reviewed changes

sherlock-admin added 28 commits December 4, 2024 15:21

Fix Review

8c2ce9b

Fix Review

8ce64c0

Fix Review

9166296

Fix Review

30e3fca

Fix Review

a38c134

Fix Review

3c85724

Fix Review

b85757a

Fix Review

1144bd6

Fix Review

b581e92

Fix Review

7ac479b

Fix Review

e50d975

Fix Review

6d88a6c

Fix Review

444a648

Fix Review

c0c172c

Fix Review

1eadb3f

Fix Review

9ed9631

Fix Review

f690a61

Fix Review

6d1f00a

Fix Review

1aa6803

Fix Review

aa3bf34

Fix Review

4724c2c

Fix Review

d1ba154

Fix Review

271278c

Fix Review

947e35e

Fix Review

e0f6401

Fix Review

191c2ea

Fix Review

c09678d

Fix Review

b4b6b04

rcstanciu closed this Dec 4, 2024

rcstanciu deleted the fix-review branch December 4, 2024 15:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Review #1

Fix Review #1

sherlock-admin commented Dec 2, 2024

sherlock-admin Dec 2, 2024

sherlock-admin Dec 2, 2024

sherlock-admin Dec 2, 2024

sherlock-admin Dec 2, 2024

sherlock-admin Dec 2, 2024

sherlock-admin Dec 2, 2024

sherlock-admin Dec 2, 2024

sherlock-admin Dec 2, 2024

sherlock-admin Dec 2, 2024

sherlock-admin Dec 2, 2024

sherlock-admin Dec 2, 2024

sherlock-admin Dec 2, 2024

sherlock-admin Dec 2, 2024

sherlock-admin Dec 2, 2024

sherlock-admin Dec 2, 2024

sherlock-admin Dec 2, 2024

sherlock-admin Dec 2, 2024

sherlock-admin Dec 2, 2024

sherlock-admin Dec 2, 2024

sherlock-admin Dec 2, 2024

sherlock-admin Dec 2, 2024

sherlock-admin Dec 2, 2024

sherlock-admin Dec 2, 2024

sherlock-admin Dec 2, 2024

sherlock-admin Dec 2, 2024

sherlock-admin Dec 2, 2024

sherlock-admin Dec 2, 2024

sherlock-admin Dec 2, 2024

sherlock-admin Dec 2, 2024

		PoolExchange memory exchange = getPoolExchange(exchangeId);
		uint256 scaledReserveRatio = uint256(exchange.reserveRatio) * 1e10;

		uint256 priceScaled = unwrap(wrap(exchange.reserveBalance).div(denominator));

		price = priceScaled / tokenPrecisionMultipliers[exchange.reserveAsset];

		uint256 scaledAmountOut = _getScaledAmountOut(exchange, tokenIn, tokenOut, scaledAmountIn);


		amountIn = scaledAmountIn / tokenPrecisionMultipliers[tokenIn];
		amountIn = scaledAmountInWithExitContribution / tokenPrecisionMultipliers[tokenIn];

		require(newRatioUint > 0, "New ratio must be greater than 0");

		uint256 allowedSlippage = (exchange.reserveRatio * maxSlippagePercentage) / MAX_WEIGHT;
		require(exchange.reserveRatio - newRatioUint <= allowedSlippage, "Slippage exceeded");

		uint256 contractReserveBalance = IERC20(exchange.reserveAsset).balanceOf(reserve) *
		(10 ** (18 - IERC20Metadata(exchange.reserveAsset).decimals()));

Fix Review #1

Fix Review #1

Conversation

sherlock-admin commented Dec 2, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment