Skip to content

Commit

Permalink
Upload reports
Browse files Browse the repository at this point in the history
  • Loading branch information
sherlock-admin committed Dec 4, 2024
1 parent e336e06 commit 254b2b4
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 0 deletions.
Binary file added Audit_Report.pdf
Binary file not shown.
28 changes: 28 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,20 @@ function initialize(address unlockRecipient, int96 unlockFlowRate, int96 taxFlow

Add a way to stop the flow and receive the deposit back.



## Discussion

**0xPilou**

Fix for this issue is included in the following PR : https://github.com/superfluid-finance/fluid/pull/8

**sherlock-admin2**

The protocol team fixed this issue in the following PRs/commits:
https://github.com/superfluid-finance/fluid/pull/8


# Issue M-1: An attacker may DoS user Fluid balance increases by frontrunning `FluidLocker::claim()` calls and calling `EP_PROGRAM_MANAGER::batchUpdateUserUnits()` directly

Source: https://github.com/sherlock-audit/2024-11-superfluid-locking-contract-judging/issues/19
Expand Down Expand Up @@ -271,6 +285,20 @@ function claim(uint256 programId, uint256 totalProgramUnits, uint256 nonce, byte

The locker should have a separate method to connect to the pool.



## Discussion

**0xPilou**

Fix for this issue is included in the following PR : https://github.com/superfluid-finance/fluid/pull/9

**sherlock-admin2**

The protocol team fixed this issue in the following PRs/commits:
https://github.com/superfluid-finance/fluid/pull/9


# Issue M-2: `FluidLocker::_getUnlockingPercentage()` divides before multiplying, suffering a significant precision error

Source: https://github.com/sherlock-audit/2024-11-superfluid-locking-contract-judging/issues/22
Expand Down

0 comments on commit 254b2b4

Please sign in to comment.