Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction of --tag optional argument for tag handling #2170

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Gregory-rt
Copy link

As mentioned in #2164, this pull request aims to introduce functionality in order to allow Sherlock to search through sites that other than a username need also a tag in order to identify an account. The solution proposed is an optional argument --tag which would allow the user to input that tag, a boolean tag_required and a # in the url of those sites. Given the argument tag sherlock will return all sites where tag_required is false/non existent replacing only the {} with the username, and those in which it is true it would also replace the # with the given tag.

If #2169 is merged, due to similarities this should be closed.

@roxerj
Copy link

roxerj commented Jun 12, 2024

With this functionality, you can't search for multiple usernames because only one tag is provided, while in #2169 you can search for multiple usernames e.g. sherlock sophie#1911 "normalus bahuras#euw" --tag
Also sherlock sophie --tag 1911 returns a lot of other results with a username "sophie" without a tag, and only one of them might be the one you're looking for, with a tag. "sophie" is a generic name so there are many unwanted results on various websites.

@Gregory-rt
Copy link
Author

With this functionality, you can't search for multiple usernames because only one tag is provided, while in #2169 you can search for multiple usernames e.g. sherlock sophie#1911 "normalus bahuras#euw" --tag

That is correct, multiple tags are not supported with this implementation, although multiple usernames is supported (all are being searched with the tag given).

Also sherlock sophie --tag 1911 returns a lot of other results with a username "sophie" without a tag, and only one of them might be the one you're looking for, with a tag. "sophie" is a generic name so there are many unwanted results on various websites.

This was intended, with this implementation --tag allows you to broaden the sites pool, with the inclusion of sites that require a tag to be searched through. I didnt see it as a way to search through only those sites but a way to also search these sites.

@ppfeister
Copy link
Member

Please reference #2169 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants