Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Except ImportError when not packaged #2213

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Except ImportError when not packaged #2213

merged 3 commits into from
Jul 8, 2024

Conversation

ppfeister
Copy link
Member

Closes #2204

@ppfeister ppfeister added the staged - do not merge PR is staged for coordinated release label Jul 1, 2024
@ppfeister ppfeister force-pushed the 2204-alert-if-script branch from d330136 to 0ece8bf Compare July 1, 2024 02:32
@ppfeister ppfeister mentioned this pull request Jul 1, 2024
Closed
@ppfeister
Copy link
Member Author

Example issues: #2203 #2168 #2221 #2222 (this will clear up a lot of confusion when ready to merge)

@ppfeister ppfeister merged commit 2680cc8 into master Jul 8, 2024
16 checks passed
@ppfeister ppfeister deleted the 2204-alert-if-script branch July 8, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdushantha sdushantha sdushantha approved these changes

Assignees
No one assigned
Labels
staged - do not merge PR is staged for coordinated release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check if Sherlock is package or script at runtime
2 participants
@ppfeister @sdushantha