Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed speedrun site support #2288 #2291

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Suramyavns
Copy link

No description provided.

@ppfeister
Copy link
Member

This PR seems to duplicate Speedrun, and with two different detection methods. Safe to say that this is unintentional?

PS - The addition of username_unclaimed is going to make this fail schema validation.

@Suramyavns
Copy link
Author

I removed the duplication of speedrun and fixed the error checking in the existing site data for speedrun

@Suramyavns
Copy link
Author

Suramyavns commented Sep 12, 2024

hey @ppfeister
this is one of my first FOSS contributions I just wanted to know if my PR would be merged soon

@ppfeister
Copy link
Member

Busy week is all. Schema wise it's good now, I've just gotta validate the check when I have a moment. Won't be long though as long as it checks out 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants