-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ja] cs-230-recurrent-neural-networks #146
Conversation
Awesome to see your work @scrambleegg7, thank you! Now, let's start the review process! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Started reviewing this document. Please have a look at my comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and added several comments on 25. to 29.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed from 30. to 40.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed from 41. to 52.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed until 71.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completed reviewing the entire document.
@scrambleegg7, could you check my review comments and include some of the suggestions to your commits? |
Yes, I have gone through. I think everything is fine. Thank you for your great contributions and workings. |
@scrambleegg7 Thank you! Could you incorporate my suggestions following this help article? |
agreed updates. Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <8402782+yoshiyukinakai@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is OK with me.
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <8402782+yoshiyukinakai@users.noreply.github.com>
I got reviewer's final comment to integrate updated context into live feed. |
Hi Shervine, |
Hi @shervinea, a team of Machine Learning Tokyo members completed translation and review. Could you check if you can merge this pull request? |
Hi @yoshiyukinakai, thanks for the mention. @scrambleegg7 my apologies, I did not see your message. Thank you both for your hard work work! I will proceed with the merge. |
I have maintained Japanese version and uploaded to master. Please review my parts.