Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] cs-230-recurrent-neural-networks #146

Merged
merged 54 commits into from
Sep 3, 2019

Conversation

scrambleegg7
Copy link
Contributor

I have maintained Japanese version and uploaded to master. Please review my parts.

@shervinea
Copy link
Owner

Awesome to see your work @scrambleegg7, thank you! Now, let's start the review process!

@shervinea shervinea added the reviewer wanted Looking for a reviewer label May 29, 2019
@shervinea shervinea mentioned this pull request Jun 3, 2019
Copy link
Contributor

@yoshiyukinakai yoshiyukinakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Started reviewing this document. Please have a look at my comments.

ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
Copy link
Contributor

@yoshiyukinakai yoshiyukinakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and added several comments on 25. to 29.

ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
Copy link
Contributor

@yoshiyukinakai yoshiyukinakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed from 30. to 40.

ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
Copy link
Contributor

@yoshiyukinakai yoshiyukinakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed from 41. to 52.

ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
Copy link
Contributor

@yoshiyukinakai yoshiyukinakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed until 71.

ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
Copy link
Contributor

@yoshiyukinakai yoshiyukinakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed reviewing the entire document.

ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
@yoshiyukinakai
Copy link
Contributor

@scrambleegg7, could you check my review comments and include some of the suggestions to your commits?

@scrambleegg7
Copy link
Contributor Author

@scrambleegg7, could you check my review comments and include some of the suggestions to your commits?

Yes, I have gone through. I think everything is fine. Thank you for your great contributions and workings.

@yoshiyukinakai
Copy link
Contributor

@scrambleegg7 Thank you! Could you incorporate my suggestions following this help article?
https://help.github.com/ja/articles/incorporating-feedback-in-your-pull-request

scrambleegg7 and others added 16 commits August 28, 2019 09:07
agreed updates.

Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
scrambleegg7 and others added 20 commits August 28, 2019 09:20
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <fpnz.tams@gmail.com>
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <8402782+yoshiyukinakai@users.noreply.github.com>
Copy link
Contributor Author

@scrambleegg7 scrambleegg7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is OK with me.

ja/recurrent-neural-networks.md Outdated Show resolved Hide resolved
Co-Authored-By: Yoshiyuki Nakai 中井喜之 <8402782+yoshiyukinakai@users.noreply.github.com>
@scrambleegg7
Copy link
Contributor Author

I got reviewer's final comment to integrate updated context into live feed.

@scrambleegg7
Copy link
Contributor Author

Hi Shervine,
Would you please merge our updates contexts (Recurrent Neural Network Japanese version) ?
We have worked out the reviewers comments and packed them.

@yoshiyukinakai
Copy link
Contributor

Hi @shervinea, a team of Machine Learning Tokyo members completed translation and review. Could you check if you can merge this pull request?

@shervinea
Copy link
Owner

Hi @yoshiyukinakai, thanks for the mention. @scrambleegg7 my apologies, I did not see your message.

Thank you both for your hard work work! I will proceed with the merge.

@shervinea shervinea reopened this Sep 3, 2019
@shervinea shervinea merged commit c3df2fe into shervinea:master Sep 3, 2019
@shervinea shervinea changed the title [ja] Recurrent Neural Networks [ja] cs-230-recurrent-neural-networks Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewer wanted Looking for a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants