Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ar] cs-229-unsupervised-learning #88

Merged
merged 11 commits into from
Nov 5, 2019
Merged

Conversation

redouanelg
Copy link
Contributor

@redouanelg redouanelg commented Oct 21, 2018

Unsupervised learning, in progress

@shervinea shervinea added the in progress Work in progress label Oct 21, 2018
@redouanelg
Copy link
Contributor Author

Hi @shervinea, done with the translation. Thank you.

@shervinea
Copy link
Owner

Thanks for your work @redouanelg! Now, let's start the review process.

@shervinea shervinea added reviewer wanted Looking for a reviewer and removed in progress Work in progress labels Dec 16, 2018
@qunaieer
Copy link
Contributor

qunaieer commented Sep 2, 2019

Hello @shervinea
How can I review this file? What is the process? I am not sure from where should I download it.

@shervinea
Copy link
Owner

Hi @qunaieer, thank you for helping out with this review!

You can go to the 'Files' tab and write down comments when applicable using the '+' button of the associated lines.

Copy link
Contributor

@qunaieer qunaieer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @redouanelg @shervinea ,
I have done reviewing this translation, and added all my comments. Thank you for you great work.
I have to mention that all terminologies translations were got from (https://www.nmthgiat.com/terminology/) where it was translated and agreed on by experts in machine learning and Arabic language, and it is suggested to unify all our translations using it.
Notes about the changes:
-some changes are minimal (e.g, adding some letters or words or minor corrections).
-some of them are major that alter the meaning (correct it), but they are very few.

  • In all comments I have copied your translations, do my review, and pasted back as a comment. This way it is easier for you to just copy the whole line.

Best regards,
Fares

ar/cheatsheet-unsupervised-learning.md Outdated Show resolved Hide resolved
ar/cheatsheet-unsupervised-learning.md Outdated Show resolved Hide resolved
ar/cheatsheet-unsupervised-learning.md Outdated Show resolved Hide resolved
ar/cheatsheet-unsupervised-learning.md Outdated Show resolved Hide resolved
ar/cheatsheet-unsupervised-learning.md Outdated Show resolved Hide resolved
ar/cheatsheet-unsupervised-learning.md Outdated Show resolved Hide resolved
ar/cheatsheet-unsupervised-learning.md Outdated Show resolved Hide resolved
ar/cheatsheet-unsupervised-learning.md Outdated Show resolved Hide resolved
ar/cheatsheet-unsupervised-learning.md Outdated Show resolved Hide resolved
ar/cheatsheet-unsupervised-learning.md Outdated Show resolved Hide resolved
@redouanelg
Copy link
Contributor Author

Thanks a lot dear @qunaieer for your high quality work.

Dear @shervinea, how should I proceed, can you approve the reviews? or should I do something on my side? Thanks.

@shervinea
Copy link
Owner

Thanks @qunaieer for your thorough work and thanks @redouanelg for reaching out.

@redouanelg each time you agree with a suggestion, you can implement the associated change on the .md file and then mark the corresponding conversation as 'resolved'.

@redouanelg
Copy link
Contributor Author

Done, thank you all.

@shervinea shervinea merged commit e1a9583 into shervinea:master Nov 5, 2019
@shervinea shervinea changed the title [ar] Unsupervised Learning [ar] cs-229-unsupervised-learning Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewer wanted Looking for a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants