-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ar] cs-229-unsupervised-learning #88
Conversation
Hi @shervinea, done with the translation. Thank you. |
Thanks for your work @redouanelg! Now, let's start the review process. |
Hello @shervinea |
Hi @qunaieer, thank you for helping out with this review! You can go to the 'Files' tab and write down comments when applicable using the '+' button of the associated lines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @redouanelg @shervinea ,
I have done reviewing this translation, and added all my comments. Thank you for you great work.
I have to mention that all terminologies translations were got from (https://www.nmthgiat.com/terminology/) where it was translated and agreed on by experts in machine learning and Arabic language, and it is suggested to unify all our translations using it.
Notes about the changes:
-some changes are minimal (e.g, adding some letters or words or minor corrections).
-some of them are major that alter the meaning (correct it), but they are very few.
- In all comments I have copied your translations, do my review, and pasted back as a comment. This way it is easier for you to just copy the whole line.
Best regards,
Fares
Thanks a lot dear @qunaieer for your high quality work. Dear @shervinea, how should I proceed, can you approve the reviews? or should I do something on my side? Thanks. |
Thanks @qunaieer for your thorough work and thanks @redouanelg for reaching out. @redouanelg each time you agree with a suggestion, you can implement the associated change on the |
Done, thank you all. |
Unsupervised learning, in progress