This repository has been archived by the owner on Nov 6, 2024. It is now read-only.
Tab component #177
Merged
Tab component #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scote
force-pushed
the
tab
branch
4 times, most recently
from
eb0be64 to
7c8d25d
Compare
scote
force-pushed
the
tab
branch
2 times, most recently
from
056ce95 to
d6e414c
Compare
jfcere
reviewed
Sep 26, 2017
src/app/tab/tab.component.ts
Outdated
| onShow: this.onShow, | ||
| responsiveThreshold: this.responsiveThreshold, | ||
| swipeable: this.swipeable, | ||
| } |
src/app/tab/tab.component.ts
Outdated
| } | ||
|
|
||
| // need setTimeout otherwise loading directly on the page cause an error | ||
| this.renderer.invokeElementMethod($(this.tabs.nativeElement), 'tabs', [options]); |
src/app/tab/tab.component.ts
Outdated
| } | ||
|
|
||
| // need setTimeout otherwise loading directly on the page cause an error | ||
| this.renderer.invokeElementMethod($(this.tabs.nativeElement), 'tabs', [options]); |
|
|
||
| it('should select tab item 2', async() => { | ||
|
|
||
| buildComponent<any>(` |
There was a problem hiding this comment.
Remove <any> everywhere for buildComponent
- Add somes examples in demo page. - Add new property for external link in tab.
- Add tab component view test
jfcere
suggested changes
Oct 12, 2017
demo-app/yarn.lock
Outdated
| @@ -3691,7 +3691,7 @@ ng2-markdown-to-html@^1.3.1: | |||
| marked "^0.3.6" | |||
| prismjs "^1.6.0" | |||
|
|
|||
| "ng2-materialize@file:../": | |||
| "ng2-materialize@file:..": | |||
There was a problem hiding this comment.
Keep the / ... this is why AppVeyor complains
jfcere
approved these changes
Oct 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100
First version of tab component. We will enhance it on second version.
✔️ Ready to be reviewed/merged