Add module for all components #237

scote · 2017-11-06T03:14:20Z

Add lazy load to demo app page
Add index.ts to folders.

- Add lazy load to demo app page - Add index.ts to folders.

jfcere · 2017-11-07T03:57:26Z

appveyor.yml

@@ -13,13 +13,12 @@ platform:

 install:
  - ps: Install-Product node $env:nodejs_version
-  - yarn install --frozen-lockfile --no-progress
+  - yarn install --frozen-locykfile --no-progress


--frozen-lockfile (no y)

jfcere · 2017-11-11T16:28:09Z

demo-app/src/app/collapsible/collapsible.module.ts

    CodeSnippetModule,
    CommonModule,
-    MaterializeModule,
+    MzButtonModule,


remove unused MzButtonModule

jfcere · 2017-11-11T16:41:34Z

demo-app/src/app/tab/tab.component.scss

@@ -1,3 +1,5 @@
+@import "../../_route-animation-host";
+
 .tab-content {
  padding: 5px;
 }


add line-return at the end of the file

jfcere · 2017-11-11T16:42:52Z

demo-app/src/app/tab/tab.component.ts

@@ -1,10 +1,14 @@
 import { Component } from '@angular/core';
+
+import { ROUTE_ANIMATION, ROUTE_ANIMATION_HOST } from '../app.routing.animation';
 import { IPropertyRow } from './../shared/properties-table/properties-table.component';


remove ./ in front of ./../shared/properties-table/properties-table.component

jfcere · 2017-11-11T16:45:16Z

demo-app/src/app/validation/validation.module.ts

+  MzTextAreaModule,
+  MzTimepickerModule,
+  MzValidationModule,
+


remove empty line

jfcere · 2017-11-11T16:48:15Z

src/app/checkbox/checkbox.module.ts

+import { CommonModule } from '@angular/common';
+import { NgModule } from '@angular/core';
+
+import { MzCheckboxContainerComponent } from './checkbox-container/checkbox-container.component';


could use the chaining you added with index.ts to export MzCheckboxContainerComponent ...

import { MzCheckboxContainerComponent } from './checkbox-container';

jfcere · 2017-11-11T17:14:06Z

src/app/textarea/textarea.module.ts

+import { CommonModule } from '@angular/common';
+import { NgModule } from '@angular/core';
+
+import { MzTextareaContainerComponent } from './textarea-container/textarea-container.component';


import { MzTextareaContainerComponent } from './textarea-container';

jfcere · 2017-11-11T17:14:24Z

src/app/textarea/textarea.module.ts

+import { NgModule } from '@angular/core';
+
+import { MzTextareaContainerComponent } from './textarea-container/textarea-container.component';
+import { MzTextareaPrefixDirective } from './textarea-prefix/textarea-prefix.directive';


import { MzTextareaPrefixDirective } from './textarea-prefix/';

jfcere · 2017-11-11T17:14:48Z

src/app/timepicker/timepicker.module.ts

+import { CommonModule } from '@angular/common';
+import { NgModule } from '@angular/core';
+
+import { MzTimepickerContainerComponent } from './timepicker-container/timepicker-container.component';


import { MzTimepickerContainerComponent } from './timepicker-container';

jfcere · 2017-11-11T17:15:39Z

src/app/toast/toast.module.ts

+import { CommonModule } from '@angular/common';
+import { NgModule } from '@angular/core';
+
+import { MzToastService } from './services/toast.service';


import { MzToastService } from './services';

jfcere · 2017-11-11T17:15:59Z

src/app/validation/validation.module.ts

+import { CommonModule } from '@angular/common';
+import { NgModule } from '@angular/core';
+
+import { MzErrorMessageComponent } from './error-message/error-message.component';


import { MzErrorMessageComponent } from './error-message';

jfcere · 2017-11-13T01:57:23Z

Still for this to be completed ...

Module name should be specified on each demo-page
Add example of "shared module" like Angular Material in readme.md
As it is not removed, MaterializeModule should still be mentioned in readme.md as an alternative to import everything

- Add import for each component in demo pages - Enhanced the example how to import component in readme - Add as alternative MaterializeModule can still be used in readme

jfcere · 2017-11-13T03:15:35Z

README.md

  ],
  declarations: [ HomeComponent ],
 })
 export class HomeModule { }
 ```

+
+### Alternative
+As an alternative, you can import `MaterializeModule` to make all component availables. This module is **depracated** and it will be removed in a near futur.


~~futur~~ future

I though i did this correction haha sorry

lol no problem ;) This is starting to looking good ... should be all set for merge.

Add module for all components

17dffba

- Add lazy load to demo app page - Add index.ts to folders.

scote assigned jfcere Nov 6, 2017

scote mentioned this pull request Nov 6, 2017

Add pagination component #220

Merged

6 tasks

Remove pagination from MaterializeModule

e6d4355

scote force-pushed the lazy-load-demo-app branch from aaa7939 to e6d4355 Compare November 6, 2017 03:48

Add unlink to appveyor

9cf0332

scote force-pushed the lazy-load-demo-app branch 3 times, most recently from 23bda10 to 9cea620 Compare November 7, 2017 03:21

Update appveyor

e4bd50a

scote force-pushed the lazy-load-demo-app branch from 9cea620 to e4bd50a Compare November 7, 2017 03:31

jfcere reviewed Nov 7, 2017

View reviewed changes

Fix typo error in appveyor.yml.

5a8ee16

jfcere reviewed Nov 11, 2017

View reviewed changes

jfcere added this to the 1.7.0 milestone Nov 11, 2017

scote added 4 commits November 11, 2017 16:47

Code review corrections

753152f

Fi8x radio-btton module

21e369c

Update readme

3f3e31b

Split mz-icon and mz-icon-mdi in separate module

ad97d77

Code reviews corrections

f8f2703

- Add import for each component in demo pages - Enhanced the example how to import component in readme - Add as alternative MaterializeModule can still be used in readme

jfcere reviewed Nov 13, 2017

View reviewed changes

scote added 4 commits November 12, 2017 22:20

Fix future typo in readme

9038aee

Merge branch 'master' into lazy-load-demo-app

4ec67b8

Update home.module.ts

8520c49

Fix badge module and home module

127447f

jfcere approved these changes Nov 22, 2017

View reviewed changes

jfcere merged commit 32a76c7 into master Nov 22, 2017

jfcere deleted the lazy-load-demo-app branch November 22, 2017 02:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add module for all components #237

Add module for all components #237

scote commented Nov 6, 2017

jfcere Nov 7, 2017

jfcere Nov 11, 2017

jfcere Nov 11, 2017 •

edited

Loading

jfcere Nov 11, 2017

jfcere Nov 11, 2017

jfcere Nov 11, 2017

jfcere Nov 11, 2017

jfcere Nov 11, 2017

jfcere Nov 11, 2017

jfcere Nov 11, 2017

jfcere Nov 11, 2017

jfcere commented Nov 13, 2017 •

edited

Loading

jfcere Nov 13, 2017

scote Nov 13, 2017

jfcere Nov 13, 2017

Add module for all components #237

Add module for all components #237

Conversation

scote commented Nov 6, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jfcere Nov 11, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jfcere commented Nov 13, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jfcere Nov 11, 2017 •

edited

Loading

jfcere commented Nov 13, 2017 •

edited

Loading