Skip to content
This repository has been archived by the owner on Nov 6, 2024. It is now read-only.

Remove hardcoded css class in mz-navbar-item-container #282

Merged
merged 1 commit into from
Feb 2, 2018
Merged

Remove hardcoded css class in mz-navbar-item-container #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions demo-app/src/app/navbar/navbar.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ <h5 class="light">Right aligned items</h5>

<div class="col s12">
<mz-navbar>
<a href="javascript:void(0)" class="brand-logo">Logo</a>
<a href="javascript:void(0)" class="brand-logo left">Logo</a>
<mz-navbar-item-container [align]="'right'">
<mz-navbar-item><a href="javascript:void(0)">Sass</a></mz-navbar-item>
<mz-navbar-item><a href="javascript:void(0)">Components</a></mz-navbar-item>
Expand Down Expand Up @@ -78,7 +78,7 @@ <h5 class="light">Centering the logo</h5>
<div class="col s12">
<mz-navbar>
<a href="javascript:void(0)" class="brand-logo center">Logo</a>
<mz-navbar-item-container [align]="'right'">
<mz-navbar-item-container [align]="'right'" class="hide-on-med-and-down">
<mz-navbar-item><a href="javascript:void(0)">Sass</a></mz-navbar-item>
<mz-navbar-item><a href="javascript:void(0)">Components</a></mz-navbar-item>
<mz-navbar-item><a routerLink="js">JavaScript</a></mz-navbar-item>
Expand All @@ -95,13 +95,13 @@ <h5 class="light">Centering the logo, and left and right items</h5>

<div class="col s12">
<mz-navbar>
<mz-navbar-item-container [align]="'left'">
<mz-navbar-item-container [align]="'left'" class="hide-on-med-and-down">
<mz-navbar-item><a routerLink="js">JavaScript</a></mz-navbar-item>
<mz-navbar-item><a href="javascript:void(0)">Components</a></mz-navbar-item>
<mz-navbar-item><a href="javascript:void(0)">Sass</a></mz-navbar-item>
</mz-navbar-item-container>
<a href="javascript:void(0)" class="brand-logo center">Logo</a>
<mz-navbar-item-container [align]="'right'">
<mz-navbar-item-container [align]="'right'" class="hide-on-med-and-down">
<mz-navbar-item><a href="javascript:void(0)">Sass</a></mz-navbar-item>
<mz-navbar-item><a href="javascript:void(0)">Components</a></mz-navbar-item>
<mz-navbar-item><a routerLink="js">JavaScript</a></mz-navbar-item>
Expand All @@ -118,7 +118,7 @@ <h5 class="light">Active items</h5>

<div class="col s12">
<mz-navbar>
<a href="javascript:void(0)" class="brand-logo">Logo</a>
<a href="javascript:void(0)" class="brand-logo left">Logo</a>
<mz-navbar-item-container [align]="'right'">
<mz-navbar-item><a href="javascript:void(0)">Sass</a></mz-navbar-item>
<mz-navbar-item><a href="javascript:void(0)">Components</a></mz-navbar-item>
Expand All @@ -142,7 +142,7 @@ <h5 class="light">Navbar dropdown menu</h5>
<li><a href="javascript:void(0)">three</a></li>
</ul>
<mz-navbar>
<a href="javascript:void(0)" class="brand-logo">Logo</a>
<a href="javascript:void(0)" class="brand-logo left">Logo</a>
<mz-navbar-item-container [align]="'right'">
<mz-navbar-item><a href="javascript:void(0)">Sass</a></mz-navbar-item>
<mz-navbar-item><a href="javascript:void(0)">Components</a></mz-navbar-item>
Expand Down
2 changes: 1 addition & 1 deletion src/app/navbar/navbar-item-container/navbar-item-container.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<ul id="nav-mobile" class="{{ align }} hide-on-med-and-down">
<ul id="nav-mobile" class="{{ align }}">
<ng-content></ng-content>
</ul>
1 change: 0 additions & 1 deletion src/app/navbar/navbar-item-container/navbar-item-container.component.view.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ describe('MzNavbarItemContainerComponent:view', () => {

expect(itemContainer()).toBeTruthy();
expect(itemContainer().id).toContain('nav-mobile');
expect(itemContainer().classList).toContain('hide-on-med-and-down');
});
}));

Expand Down