This repository has been archived by the owner on Nov 6, 2024. It is now read-only.
remove p surrounding over modal content #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scote
previously approved these changes
May 15, 2018
jfcere
suggested changes
May 15, 2018
src/app/modal/modal.component.html
Outdated
| <p> | ||
| <ng-content select="mz-modal-content"></ng-content> | ||
| </p> | ||
| <ng-content select="mz-modal-content"></ng-content> |
There was a problem hiding this comment.
@MariuszHenn thanks for your PR!
Like you said in the issue, the p element should be replaced with a div. Otherwise if somebody would write ...
<mz-modal>
<mz-modal-header>Header</mz-modal-header>
<mz-modal-content>Content</mz-modal-content>
</mz-modal>The content of mz-modal-header and mz-modal-content would be side-by-side instead of one over each other.
Note that changing p for div will only remove top/bottom margin in the mz-modal-content leaving more control over the spacing.
jfcere
approved these changes
May 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#324