Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button doesn't load when navigating on GitHub #25

Closed
Keith94 opened this issue Sep 22, 2017 · 1 comment
Closed

Button doesn't load when navigating on GitHub #25

Keith94 opened this issue Sep 22, 2017 · 1 comment
Assignees
Labels

Comments

@Keith94
Copy link

Keith94 commented Sep 22, 2017

It may be a bug or limitation in the WebExtensions API, but I wanted to report it just in case. ;)

Steps to reproduce

  1. Navigate to https://github.com/shgysk8zer0/awesome-rss/issues
  2. Click on one of the other tabs (e.g. Pull requests)

Expected behavior

RSS icon should(?) re-appear or stay visible in the url bar

Actual behavior

RSS icon disappears from url bar and requires reloading the page to appear again

@shgysk8zer0 shgysk8zer0 self-assigned this Sep 22, 2017
@shgysk8zer0
Copy link
Owner

Confirmed. It also suffers from the same issue when navigating using the back/forward buttons.
In the case of the reported issue, the problem seems to be that the DOMContentLoaded event isn't triggered on fetch/XHR.

shgysk8zer0 added a commit that referenced this issue Sep 22, 2017
This will cause feeds to update on navigation.
Fixes #25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants