Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Turkish translations #170
base: master
Are you sure you want to change the base?
Improve Turkish translations #170
Changes from all commits
5bc3a7aFile filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing end quote.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now this is an interesting string. Actually it should be like this innit:
The space before
artıkseems unnecessary. I changed the original double quotes around%2to single quotes, to make it more understandable, that it is surrounded by literal quotes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well that's a tricky one. :-)
Let's assume %2 equals
FreeDOSThe
/s-turns off spacing between parameters. So,/s- /f %1 '%2' /f %3 "art�k kurulabilir."would displayFreeDOSart�k kurulabilir.because no space will be inserted between the'%2'and the following text string.So the space after the quote forces one. Don't know why a
/s-was placed in there. Looking at the BAT file that uses that string it does not modify the spacing behaviour.vecho /k0 /t %FLANG% INSTALL %TFH% "%OS_NAME% %OS_VERSION%" %TFF%(FLANG is the language file, TFH and TFF are theme color values and OS_NAME + OS_VERSION are in quotes and passed as a single parameter.)
Possibly, a long time ago that invocation turn off spacing and the
/s-in the translation file was just a reminder of the state. However, it would have been better to use/s+to turn back on spacing.So, remove the
/s-from the string and the space following the quote won't be needed.An example of
/s-behaviour...vecho A B /s- C D E "F G" "H" /s+ I J "K L" "M N"displaysA BCDEF GH I J K L M NThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You do not want to use the
/s-switch here. That switch turns off spacing between parameter strings and would cause all the words to run together as one. I'm not sure why there was a space in the original quoted string. But, it should be fine without it. So either of these should be fine...BACKUP=/f %1 %2 /f %3 s�r�c�s�nde kurulu bir i�letim sistemi bulundu.or
BACKUP=/f %1 %2 /f %3 "s�r�c�s�nde kurulu bir i�letim sistemi bulundu."There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't want to use
/s-here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't want to use
/s-here.