feat: do not dedup loggers with same name

shigma · Oct 26, 2023 · b62c896 · b62c896
1 parent b45abe1
commit b62c896
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 6 deletions.
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "reggol",
   "description": "Logger for professionals",
-  "version": "1.6.0",
+  "version": "1.6.1",
   "sideEffects": false,
   "main": "lib/node.js",
   "types": "index.d.ts",

diff --git a/src/shared.ts b/src/shared.ts
@@ -81,7 +81,6 @@ class Logger {
 
   // global registry
   static formatters: Record<string, Logger.Formatter> = Object.create(null)
-  static instances: Record<string, Logger> = Object.create(null)
 
   static format(name: string, formatter: Logger.Formatter) {
     this.formatters[name] = formatter
@@ -132,9 +131,6 @@ class Logger {
   }
 
   constructor(public name: string, public meta?: any) {
-    if (name in Logger.instances) return Logger.instances[name]
-
-    Logger.instances[name] = this
     this.createMethod('success', Logger.SUCCESS)
     this.createMethod('error', Logger.ERROR)
     this.createMethod('info', Logger.INFO)

diff --git a/tests/index.spec.ts b/tests/index.spec.ts
@@ -30,7 +30,6 @@ describe('Logger API', () => {
   it('basic support', () => {
     logger = new Logger('test').extend('logger')
     expect(logger.name).to.equal('test:logger')
-    expect(logger).to.equal(new Logger('test:logger'))
     logger = new Logger('test')
   })