ウェブフックの recording_metadata の送信可否を設定できるようにする #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voluntas
reviewed
Oct 30, 2024
| @@ -56,6 +56,8 @@ type Config struct { | |||
| WebhookTypeSplitArchiveEndUploaded string `ini:"webhook_type_split_archive_end_uploaded"` | |||
| WebhookTypeReportUploaded string `ini:"webhook_type_report_uploaded"` | |||
|
|
|||
| ExcludeWebhookRecordingMetadata bool `ini:"exclude_webhook_recording_metadata"` | |||
voluntas
approved these changes
Oct 30, 2024
…into feature/add-recording-metadata-config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
変更履歴
exclude_webhook_recording_metadataを追加し、report ファイルアップロード後のウェブフックにrecording_metadataを含めるかどうか設定できるようにするfalseでrecording_metadataを送信するウェブフックに含めるtrueを設定するとレポートファイルにrecording_metadataまたはmetadataが含まれていてもウェブフックには含めないThis pull request introduces a new configuration option to control the inclusion of
recording_metadatain webhook payloads after a report file upload. The key changes involve adding this configuration to relevant files and updating the logic to respect the new setting.Configuration Updates:
config.go: AddedExcludeWebhookRecordingMetadatato theConfigstruct to allow users to configure the exclusion ofrecording_metadatain webhook payloads.config_example.ini: Provided an example configuration entry forexclude_webhook_recording_metadatato guide users on how to set this option.Logic Updates:
uploader.go: Updated thehandleReportfunction to check the newExcludeWebhookRecordingMetadatasetting and conditionally includerecording_metadatain the webhook payload.Documentation:
CHANGES.md: Documented the newexclude_webhook_recording_metadataconfiguration option, explaining its default behavior and how to configure it.