Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/e2e test signaling #575

Merged
merged 4 commits into from
Dec 8, 2024
Merged

Feature/e2e test signaling #575

merged 4 commits into from
Dec 8, 2024

Conversation

voluntas
Copy link
Member

@voluntas voluntas commented Dec 8, 2024

This pull request includes several changes to add new end-to-end (E2E) tests, update the SoraClient class, and modify the package.json file. The key changes are summarized below:

E2E Testing Enhancements:

  • Added a new E2E test for "type": "switched" in tests/switched.spec.ts. This test verifies various aspects of the signaling and connection process, including checking console logs and obtaining statistics reports.

Code Updates:

  • Updated the SoraClient class in examples/sendonly/main.mts to include a new onSignaling method for handling signaling events. This method logs signaling events of type onmessage-switched. [1] [2]
  • Renamed the onnotify method to onNotify for consistency.

Documentation and Configuration:

  • Updated CHANGES.md to include the addition of the new E2E test and changes to the canary release process.
  • Modified package.json to update the packageManager version and adjust the formatting of the files array. [1] [2]

@voluntas voluntas self-assigned this Dec 8, 2024
@voluntas voluntas changed the title [WIP] Feature/e2e test signaling Feature/e2e test signaling Dec 8, 2024
@voluntas voluntas merged commit 807d3fc into develop Dec 8, 2024
4 checks passed
@voluntas voluntas deleted the feature/e2e-test-signaling branch December 8, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant