Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type: close の E2E テストを追加する #576

Merged
merged 8 commits into from
Dec 8, 2024

Conversation

voluntas
Copy link
Member

@voluntas voluntas commented Dec 8, 2024

This pull request includes several updates to the configuration files, workflow files, and the addition of new tests and examples. The key changes focus on updating the environment configuration, modifying GitHub Actions workflows, and adding new E2E tests and examples.

Environment Configuration:

  • Added VITE_SORA_API_URL to .env.template for specifying the Sora API URL.

GitHub Actions Workflow Updates:

  • Updated the runs-on parameter to ubuntu-24.04 in multiple workflow files (ci.yaml, e2e-test.yml, and npm-pkg-e2e-test.yml). [1] [2] [3]
  • Added tailscale/github-action@v2 to e2e-test.yml and npm-pkg-e2e-test.yml for setting up Tailscale. [1] [2]

New Examples:

  • Added a new example for data_channel_signaling_only with index.html and main.mts files to demonstrate Sora SDK usage. [1] [2]

E2E Tests:

  • Added new E2E tests for type: close and type: switched in tests/type_close.spec.ts and tests/type_switched.spec.ts. [1] [2]
  • Removed old E2E test for sendonly type: switched in tests/switched.spec.ts.

Miscellaneous:

  • Updated CHANGES.md to include the addition of the new E2E test for "type": "close".
  • Disabled CORS in playwright.config.mts by adding relevant Chrome flags.
  • Added a new entry for data_channel_signaling_only in vite.config.mjs.

@voluntas voluntas merged commit 98161dd into develop Dec 8, 2024
41 checks passed
@voluntas voluntas deleted the feature/add-e2e-test-signaling-message-type-close branch December 8, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant