Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest not using <NativeDlls> in .props file #1360

Closed
sdcb opened this issue Dec 28, 2021 · 1 comment · Fixed by #1361
Closed

Suggest not using <NativeDlls> in .props file #1360

sdcb opened this issue Dec 28, 2021 · 1 comment · Fixed by #1361

Comments

@sdcb
Copy link

sdcb commented Dec 28, 2021

Because <NativeDlls> looks pretty generic, so many project might be using this name, if one project include 2 NuGet packages that include native library which using <NativeDlls> defined in their prop file, these 2 <NativeDlls> will conflicted(and it happens in my project):

https://github.com/shimat/opencvsharp/blob/51fee5e/nuget/OpenCvSharp4.runtime.win.props#L3

Maybe using a more specific word here will better, like <OpenCvSharp4ExternalNativeDlls>

shimat added a commit that referenced this issue Dec 28, 2021
shimat added a commit that referenced this issue Dec 28, 2021
@shimat
Copy link
Owner

shimat commented Dec 28, 2021

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants