add implicit convert operator for all variants of size struct #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimat
reviewed
Mar 7, 2023
| @@ -73,22 +73,32 @@ public Size(double width, double height) | |||
| return !lhs.Equals(rhs); | |||
| } | |||
|
|
|||
| public static implicit operator Size(Size2d size) | |||
| { | |||
| return new(size.Width, size.Height); | |||
There was a problem hiding this comment.
I think Size -> Size2d is OK, but Size2d -> Size should be marked as explicit. This is because there is no implicit conversion from double to int in the case of scalar values. (For example, double d = 1; is OK but int i = 1.23; causes an error.)
n0099
commented
Mar 7, 2023
shimat
reviewed
Mar 7, 2023
Co-authored-by: shimat <schimatk@gmail.com>
Co-authored-by: shimat <schimatk@gmail.com>
|
Thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.