Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added logging facilities #1571

Merged
merged 2 commits into from
Jun 5, 2023
Merged

Added logging facilities #1571

merged 2 commits into from
Jun 5, 2023

Conversation

GrigoryanArtem
Copy link
Contributor

No description provided.

shimat
shimat reviewed May 20, 2023
View reviewed changes
Copy link
Owner

@shimat shimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

src/OpenCvSharp/Modules/core/Enum/LogLevel.cs Outdated
/// <summary>
/// for using in setLogVevel() call
/// </summary>
LOG_LEVEL_SILENT = 0,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest removing the common prefix LOG_LEVEL_ from each field name, which is the same as the type name.

Suggested change
LOG_LEVEL_SILENT = 0,
SILENT = 0,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's a good point.

@shimat
Copy link
Owner

shimat commented Jun 5, 2023

CI is not successful but this will be merged. Thank you very much.

@shimat shimat merged commit 117600e into shimat:master Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shimat shimat shimat left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GrigoryanArtem @shimat