Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated sanity-checks.yml #27

Merged
merged 3 commits into from
Jun 3, 2023
Merged

Conversation

krishnaduttPanchagnula
Copy link
Contributor

@krishnaduttPanchagnula krishnaduttPanchagnula commented Jun 2, 2023

Closes #26

@azemetre azemetre self-assigned this Jun 2, 2023
@azemetre azemetre added the build ci/cd, linting, formatting, release management label Jun 2, 2023
@azemetre azemetre self-requested a review June 2, 2023 21:10
Copy link
Collaborator

@azemetre azemetre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very great fix, thank you so much! I was going to make a PR where I turned coverage into an environment variable, which isn't necessary with your changes. Thank you once again.

I do have one request, I haven't had time to automatically enforce commit conventions. If you could amend your commit message and force push it back up, I can approve it.

You can use the following command if needed:

git commit --amend -m 'build(actions): removing `set-output` command'

The reason for this is I'm trying out a little experiment with this repo where everything is an atomic commit that gets rebased into main.

  • amend current commit message

@krishnaduttPanchagnula
Copy link
Contributor Author

done @azemetre

@azemetre azemetre merged commit 5c7ce1f into shimman-dev:main Jun 3, 2023
@azemetre
Copy link
Collaborator

azemetre commented Jun 3, 2023

Thank you so much @krishnaduttPanchagnula for the contribution :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build ci/cd, linting, formatting, release management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use environment variables in github actions
2 participants