Apps: Update Terminal, pull from upstream #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use upstream's newer `utilities-terminal`. Use former `utilities-terminal` for Xfce Terminal. Update with newer style rounded-corners, gradients, semi-transparent borders. It now better matches the upstream Xfce Terminal icon, and gives people a choice for different terminal icons. Fix: Update `internet-mail` at 16px. Make larger to match other category/app icons (they should all be the same size in Xfce Applications Menu), use semi-transparent borders for sharper look on dark themes.
|
Going to go ahead and merge this and the ristretto PR, no objections after a few months. I do have a slight issue with the borderless terminal icon here being harder to see on dark backgrounds (esp the small size in the "Applications" panel menu). But it is upstream. And if it becomes an issue for people it's easy enough to change in the future, and should be addressed upstream if possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use upstream's newer
utilities-terminal. (Used for generic terminal stuff, as well as Xfce's "Default Apps" terminal icon)Use former
utilities-terminalfor Xfce Terminal. Update with newer style rounded-corners, gradients, semi-transparent borders. It now better matches the upstream Xfce Terminal icon.This gives people a choice for different terminal icons (upstream's can be hard to see in dark themes, esp at smaller sizes). In Xfce you can use the "Default App" "Terminal Emulator" and see upstream icon, or use "Xfce Terminal" for the updated/refreshed icon.
Left to right: Current, Upstream, Updated/Refreshed Current
(another option with the right-most icon refresh using the upstream $ symbol, but I kind of like the symbols being a bit different)
Fix:
Update
internet-mailat 16px. Made larger to now be the same size as all other Xfce "Default Apps" icons (seen in Xfce Applications Menu), use semi-transparent borders for sharper look on dark themes.