Animations/Status: Update process-working icons #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update process-working and process-working-symbolic icons to match the same newer style used for the "network connecting" animations. In Gtk, the single-frame process-working-symbolic is now animated automatically by the GtkSpinner widget. The mult-frame process-working seems to be still used by Qt, so that has been updated (including the additional CSS class info that Qt seems to use). Removed gnome-spinner related animations, PNGs.
newhoa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
process-workingicon to match the same newer style used for the "network connecting" working animations.Removed
gnome-spinnerrelated animations, PNGsas well as the multi-frame. These were removed from Gnome Icon Theme from 2006-2010 and don't seem to be used by any apps I could find (nor are they included in any modern icon themes). In Gtk, the single-frame icon,process-workingprocess-working-symbolic, is now animated via rotation by widgets automatically.Drafting this one until I can figure out if QT/KDE needs an SVG-based multi-frameprocess-working. Also not totally sure if non-symbolicprocess-workingis needed, but might be good to have it anyway in case a fallback name is used by some app somewhere.Ok, turns out Qt may still use the multi-frame
process-working, so re-added that and updated it, including the CSS/class info that Qt looks for (according to the breeze icon theme, and LXQt).